Skip to content

Commit

Permalink
bpo-37218: Change example HMAC.name, to a stronger hash
Browse files Browse the repository at this point in the history
In case readers of the documentation are taking this exmaple as some
form of recommendation, change it to a hashing alogrithm without known
collision attacks.

As https://tools.ietf.org/html/rfc6151 notes "attacks on HMAC-MD5 do not
seem to indicate a practical vulnerability when used as a message
authentication code", but "for a new protocol design, a ciphersuite with
HMAC-MD5 should not be included". On this basis I think it's best not to
mention it here.
  • Loading branch information
moreati committed Jun 10, 2019
1 parent fa8d736 commit a4864e9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Doc/library/hmac.rst
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ A hash object has the following attributes:

.. attribute:: HMAC.name

The canonical name of this HMAC, always lowercase, e.g. ``hmac-md5``.
The canonical name of this HMAC, always lowercase, e.g. ``hmac-sha256``.

.. versionadded:: 3.4

Expand Down

0 comments on commit a4864e9

Please sign in to comment.