Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On update race condition #471

Merged
merged 19 commits into from
Aug 9, 2024
Merged

On update race condition #471

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
30bf605
guard updates between transition
brocollie08 Aug 2, 2024
956fea8
simplify check
brocollie08 Aug 2, 2024
686171e
async as well
brocollie08 Aug 2, 2024
5306baa
remove some logs
brocollie08 Aug 2, 2024
96f9f24
more comment removal
brocollie08 Aug 2, 2024
210be05
lint
brocollie08 Aug 2, 2024
bd6bbce
move logic out of view
brocollie08 Aug 6, 2024
8ba0666
fix tests
brocollie08 Aug 6, 2024
380758d
revert typing change
brocollie08 Aug 6, 2024
264e069
remove top level reset of view transition state, leaving responsibili…
brocollie08 Aug 6, 2024
cb5f539
android check as well
brocollie08 Aug 7, 2024
83fbf04
cancel previous render job from android if new render job is launched
brocollie08 Aug 7, 2024
3b093ac
nullable job
brocollie08 Aug 8, 2024
b33e8c3
revert core changes
brocollie08 Aug 8, 2024
7f8c5d5
Merge branch 'main' into onUpdate-race-condition
brocollie08 Aug 9, 2024
641823d
no hermes
brocollie08 Aug 9, 2024
1cb704b
hermes only
brocollie08 Aug 9, 2024
66763cc
separate default and hermes
brocollie08 Aug 9, 2024
2dbd20e
single line
brocollie08 Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
hermes only
  • Loading branch information
@brocollie08
brocollie08 committed Aug 9, 2024
commit 1cb704b604081a2b5722885cf52d6f50db7bc3c5
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ jobs:
circle-android wait-for-boot

- run: |
bazel test --config=ci -- //android/demo:android_instrumentation_test
bazel test --config=ci --//android/player:runtime=hermes -- //android/demo:android_instrumentation_test

- run:
when: always
Expand Down