On update race condition #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adierkens
reviewed
Aug 5, 2024
core/player/src/view/view.ts
Outdated
Comment on lines
105
to
110
| resolverOptions.flowController.current?.hooks.transition.tap("view", (state1, state2) => { | ||
| this.transitioning = true; | ||
| }) | ||
| resolverOptions.flowController.current?.hooks.afterTransition.tap("view", (flowInstance) => { | ||
| this.transitioning = false; | ||
| }) |
There was a problem hiding this comment.
You'll want to use the .flow hook on the flow-controller instead of using current directly.
There was a problem hiding this comment.
while accessible. the call of that hook takes place earlier than the tap due to flow/view scope diff, so I moved the logic out to the view controller
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
=======================================
Coverage 91.93% 91.93%
=======================================
Files 339 339
Lines 26831 26831
Branches 1945 1945
=======================================
Hits 24668 24668
Misses 2149 2149
Partials 14 14 ☔ View full report in Codecov by Sentry. |
|
/canary |
sugarmanz
previously approved these changes
Aug 8, 2024
This was referenced Aug 14, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorDoes your PR have any documentation updates?
📦 Published PR as canary version:
0.8.1--canary.471.16682Try this version out locally by upgrading relevant packages to 0.8.1--canary.471.16682