Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1196 update news descr #1197

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Closes #1196 update news descr #1197

merged 2 commits into from
Jun 3, 2022

Conversation

bms63
Copy link
Collaborator

@bms63 bms63 commented Jun 3, 2022

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide
  • Updated relevant unit tests or have written new unit tests - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@bms63 bms63 linked an issue Jun 3, 2022 that may be closed by this pull request
@bms63 bms63 changed the base branch from main to devel June 3, 2022 12:22
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Code Coverage

Package Line Rate Health
admiral 92%
Summary 92% (3810 / 4153)

@esimms999-gsk esimms999-gsk self-requested a review June 3, 2022 14:06
@esimms999-gsk esimms999-gsk self-assigned this Jun 3, 2022
@esimms999-gsk esimms999-gsk merged commit 55f3580 into devel Jun 3, 2022
@esimms999-gsk esimms999-gsk deleted the 1196_update_news_descr branch June 3, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General Issue: Changelog and Description Update for 0.8.0
2 participants