Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Issue: Changelog and Description Update for 0.8.0 #1196

Closed
bms63 opened this issue Jun 1, 2022 · 0 comments · Fixed by #1197
Closed

General Issue: Changelog and Description Update for 0.8.0 #1196

bms63 opened this issue Jun 1, 2022 · 0 comments · Fixed by #1197
Assignees

Comments

@bms63
Copy link
Collaborator

bms63 commented Jun 1, 2022

Background Information

Starting off with fresh changelog is really helpful for keeping tracking of our changes. @pharmaverse/admiral what are you thoughts? Same structure as previous?

Also was going to increment the package description number from 0.7.0 to 0.8.0

Proposed new Changelog.

admiral 0.8.0

New Features

Updates of Existing Functions

Breaking Changes

Documentation

Various

admiral 0.7.0

New Features

ADLB

ADPP

  • New ADPP template script available ad_adpp.R which creates Pharmacokinetics Parameters Analysis Dataset (Create ADPP #850)

Updates of Existing Functions

Breaking Changes

  • derive_var_lstalvdt() has been deprecated in favor of derive_var_extreme_dt() (Generalize derive_var_lstalvdt() #753).

  • derive_vars_disposition_reason() now is updated such that the default is populating DCSREASP only when DSDECOD is equal to 'OTHER', which is consistent with ADaMIG_v1.3 (Update derive_disposition_reason() #886).

  • derive_vars_suppqual() has been removed from {admiral} as adding supplementary qualifiers is now done in another package called {metatools} in a function called combine_supp() and is available on CRAN (Deprecate derive_vars_suppqual #950)

  • The filter parameter in derive_var_extreme_flag() and
    derive_var_worst_flag() has been deprecated in favor of
    restrict_derivation() (Do we need a slice_derivation() function? #701).

  • The following functions and parameters, which were deprecated in previous {admiral} versions, have been removed (Documentation: Remove previously deprecated functions #1056):

    • derive_agegr_ema()
    • derive_agegr_fda()
    • derive_disposition_dt()
    • derive_disposition_status()
    • derive_extreme_flag()
    • derive_worst_flag()
    • derive_obs_number()
    • derive_disposition_reason()
    • derive_var_basec()
    • derive_baseline()
    • derive_params_exposure()
    • derive_last_dose()
    • dataset parameter in lstalvdt_source and dthcaus_source
  • The following functions were deprecated in favor of derive_vars_dy()
    (Decision on which "questioning" functions to deprecate? #1076):

    • derive_var_ady() - Derive Analysis Study Day
    • derive_var_aendy() - Derive Analysis End Relative Day
    • derive_var_astdy() - Derive Analysis Start Relative Day
  • The following functions were deprecated in favor of derive_vars_merged_dtm()
    (Decision on which "questioning" functions to deprecate? #1076):

    • derive_var_trtedtm() - Derive Datetime of Last Exposure to Treatment
    • derive_var_trtsdtm() - Derive Datetime of First Exposure to Treatment
  • The derive_var_disposition_dt() function was deprecated in favor of
    derive_vars_merged_dt() (Decision on which "questioning" functions to deprecate? #1076)

  • The derive_var_atirel() function was deprecated, as it is deemed as too
    specific for admiral. Derivations like this can be implemented calling
    mutate() and case_when().

Documentation

Various

admiral 0.6.3

Address CRAN comments raised after submitting v0.6.2 (#946)

Definition of Done

Changelog updated in devel branch and description incremented.

@bms63 bms63 self-assigned this Jun 3, 2022
bms63 added a commit that referenced this issue Jun 3, 2022
bms63 added a commit that referenced this issue Jun 3, 2022
@bms63 bms63 linked a pull request Jun 3, 2022 that will close this issue
14 tasks
@bms63 bms63 reopened this Jul 18, 2022
@bms63 bms63 closed this as completed Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant