Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage/s3: Fix proxy with no-verify-ssl flag #457

Merged
merged 17 commits into from
Jul 20, 2022
Merged

storage/s3: Fix proxy with no-verify-ssl flag #457

merged 17 commits into from
Jul 20, 2022

Commits on Jul 4, 2022

  1. storage/s3: Fix proxy with no-verify-ssl flag 

    This change fixes the problem where proxy is ignored when no-verify-ssl flag is used.

- Test environment is created to test proxy support: proxy_fake.go is added.

Fixes peak#445
    @boraberke
    boraberke committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    4b966a2 View commit details
    Browse the repository at this point in the history

  2. change Setenv method 

    Changed t.Setenv to os.Setenv as t.Setenv is not supported in go version 1.16.x
    @boraberke
    boraberke committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    afd6208 View commit details
    Browse the repository at this point in the history

  3. remove unused param

    @boraberke
    boraberke committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    7db028d View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Add comment to explain nil proxy

    @boraberke
    boraberke committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    bc5b0af View commit details
    Browse the repository at this point in the history

  2. storage/s3: Fix proxy with no-verify-ssl flag 

    This change fixes the problem where proxy is ignored when no-verify-ssl flag is used.

- Test environment is created to test proxy support: proxy_fake.go is added.

Fixes peak#445
    @boraberke
    boraberke committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    38b58ab View commit details
    Browse the repository at this point in the history

  3. change Setenv method 

    Changed t.Setenv to os.Setenv as t.Setenv is not supported in go version 1.16.x
    @boraberke
    boraberke committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    01018f7 View commit details
    Browse the repository at this point in the history

  4. remove unused param

    @boraberke
    boraberke committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    38e9696 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Merge branch 'peak:master' into fix-proxy-when-used-with-no-verify-ss… 

    …l-flag
    @boraberke
    boraberke committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    c7187e6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix-proxy-when-used-with-no-verify-ssl-flag' of github.… 

    …com:boraberke/s5cmd into fix-proxy-when-used-with-no-verify-ssl-flag
    @boraberke
    boraberke committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    a4058f6 View commit details
    Browse the repository at this point in the history

  3. fix test and change proxy localhost url

    @boraberke
    boraberke committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    fab87bc View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Fix suggestions

    @boraberke
    boraberke committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    f843152 View commit details
    Browse the repository at this point in the history

  2. Update s3_fake.go 

    Change SplitHostPort to ParseRequestURI
    @boraberke
    boraberke committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    9b7c6d6 View commit details
    Browse the repository at this point in the history

  3. Change ParseRequestURI to Parse

    @boraberke
    boraberke committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    940b1bf View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix-proxy-when-used-with-no-verify-ssl-flag

    @boraberke
    boraberke committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    860aada View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Change structure of proxy_fake

    @boraberke
    boraberke committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    da3d935 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-proxy-when-used-with-no-verify-ssl-flag

    @boraberke
    boraberke committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    accd2b6 View commit details
    Browse the repository at this point in the history

  3. Fix changes from the code review

    @boraberke
    boraberke committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    8355aec View commit details
    Browse the repository at this point in the history