storage/s3: Fix proxy with no-verify-ssl flag #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the problem where proxy is ignored when no-verify-ssl flag is used. - Test environment is created to test proxy support: proxy_fake.go is added. Fixes peak#445
boraberke
requested review from
igungor and
ilkinulas
and removed request for
a team
Changed t.Setenv to os.Setenv as t.Setenv is not supported in go version 1.16.x
This change fixes the problem where proxy is ignored when no-verify-ssl flag is used. - Test environment is created to test proxy support: proxy_fake.go is added. Fixes peak#445
Changed t.Setenv to os.Setenv as t.Setenv is not supported in go version 1.16.x
…com:boraberke/s5cmd into fix-proxy-when-used-with-no-verify-ssl-flag
ilkinulas
reviewed
Jul 13, 2022
igungor
reviewed
Jul 18, 2022
Change SplitHostPort to ParseRequestURI
ilkinulas
approved these changes
Jul 18, 2022
igungor
reviewed
Jul 18, 2022
igungor
reviewed
Jul 18, 2022
igungor
reviewed
Jul 18, 2022
igungor
reviewed
Jul 18, 2022
igungor
reviewed
Jul 18, 2022
igungor
reviewed
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the problem where proxy is ignored when no-verify-ssl flag is used.
Fixes #445