Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve closer implementation and docstrings #126

Merged
merged 6 commits into from
May 27, 2016
Merged

Improve closer implementation and docstrings #126

merged 6 commits into from
May 27, 2016

Commits on May 27, 2016

  1. Improve auto close implementation 

    - Register all envs at initialization time, not just ones created via make
- Simplify names and add more documentation on interface
- Move closer instances into the relevant modules

review-requested: @jietang
    @gdb
    gdb committed May 27, 2016
    Configuration menu
    Copy the full SHA
    773068d View commit details
    Browse the repository at this point in the history

  2. Close environments in the tests 

    This isn't strictly needed, but means there are fewer Doom
subprocesses hanging around while the tests run.
    @gdb
    gdb committed May 27, 2016
    Configuration menu
    Copy the full SHA
    9b24927 View commit details
    Browse the repository at this point in the history

  3. Use 4 space indent in comment

    @gdb
    gdb committed May 27, 2016
    Configuration menu
    Copy the full SHA
    384a954 View commit details
    Browse the repository at this point in the history

  4. Improve docstrings in core

    @gdb
    gdb committed May 27, 2016
    Configuration menu
    Copy the full SHA
    8444e8c View commit details
    Browse the repository at this point in the history

  5. Don't pass through args to __new__ 

    The __init__ method gets called once __new__ returns,
so these arguments are either ignored (Python 2) or
result in an error (Python 3). The __init__ method
automatically gets called with the correct arguments.
    @gdb
    gdb committed May 27, 2016
    Configuration menu
    Copy the full SHA
    f1f1285 View commit details
    Browse the repository at this point in the history

  6. Fixup comments

    @gdb
    gdb committed May 27, 2016
    Configuration menu
    Copy the full SHA
    ac0bb0d View commit details
    Browse the repository at this point in the history