Improve closer implementation and docstrings #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Register all envs at initialization time, not just ones created via make - Simplify names and add more documentation on interface - Move closer instances into the relevant modules review-requested: @jietang
This isn't strictly needed, but means there are fewer Doom subprocesses hanging around while the tests run.
The __init__ method gets called once __new__ returns, so these arguments are either ignored (Python 2) or result in an error (Python 3). The __init__ method automatically gets called with the correct arguments.
| @@ -31,13 +33,22 @@ class Env(object): | |||
|
|
|||
| action_space: The Space object corresponding to valid actions | |||
| observation_space: The Space object corresponding to valid observations | |||
| reward_range: A tuple corresponding to the min and max possible rewards | |||
There was a problem hiding this comment.
It doesn't look like we actually use this anywhere - should we get rid of it?
There was a problem hiding this comment.
This is for use by people's algorithms.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jietang mind reviewing?