lint

app/controllers/api/v1/search_endpoints_controller.rb

@@ -8,25 +8,25 @@ def index
         bool = ActiveRecord::Type::Boolean.new
         archived  = bool.deserialize params[:archived]
         puts "are we looking up archived?   #{archived}"
-        
-        query = current_user.search_endpoints_involved_with
-        
-        if params[:team_id]
-          @search_endpoints = current_user.search_endpoints_involved_with
-            .where(archived: archived)
-            .joins(:teams).where(teams: {id: params[:team_id] })
-        else 
-          @search_endpoints = current_user.search_endpoints_involved_with
-            .where(archived: archived)
-        end
-        
+
+        current_user.search_endpoints_involved_with
+
+        @search_endpoints = if params[:team_id]
+                              current_user.search_endpoints_involved_with
+                                .where(archived: archived)
+                                .joins(:teams).where(teams: { id: params[:team_id] })
+                            else
+                              current_user.search_endpoints_involved_with
+                                .where(archived: archived)
+                            end
+
         respond_with @search_endpoints
       end
 
       def show
         respond_with @search_endpoint
       end
-      
+
       def update
         update_params = search_endpoint_params
         bool = ActiveRecord::Type::Boolean.new
@@ -35,15 +35,15 @@ def update
           # archiving a case means current user takes it over, that should be better expressed.
           @search_endpoint.owner = current_user
           @search_endpoint.mark_archived!
-          #Analytics::Tracker.track_case_archived_event current_user, @case
+          # Analytics::Tracker.track_case_archived_event current_user, @case
           respond_with @search_endpoint
         elsif @search_endpoint.update update_params
-        #Analytics::Tracker.track_case_updated_event current_user, @case
+          # Analytics::Tracker.track_case_updated_event current_user, @case
           respond_with @search_endpoint
         else
           render json: @search_endpoint.errors, status: :bad_request
         end
-      end      
+      end
 
       private
 
@@ -53,10 +53,10 @@ def set_search_endpoint
 
         render json: { error: 'Not Found!' }, status: :not_found unless @search_endpoint
       end
-      
+
       def search_endpoint_params
         params.require(:search_endpoint).permit(:archived)
-      end      
+      end
     end
   end
 end

app/controllers/search_endpoints_controller.rb

@@ -74,7 +74,7 @@ def set_search_endpoint
   end
 
   def search_endpoint_params
-    params.require(:search_endpoint).permit(:name, :endpoint_url, :search_engine, :custom_headers, :api_method, :archived,
-                                            team_ids: [])
+    params.require(:search_endpoint).permit(:name, :endpoint_url, :search_engine, :custom_headers,
+                                            :api_method, :archived, team_ids: [])
   end
 end

app/models/judgement.rb

@@ -25,7 +25,10 @@ class Judgement < ApplicationRecord
   belongs_to :query_doc_pair
   belongs_to :user, optional: true
 
+  # rubocop:disable Rails/UniqueValidationWithoutIndex
   validates :user_id, :uniqueness => { :scope => :query_doc_pair_id }
+  # rubocop:enable Rails/UniqueValidationWithoutIndex
+
   validates :rating,
             presence: true, unless: :unrateable
 

app/models/search_endpoint.rb

@@ -31,7 +31,7 @@ class SearchEndpoint < ApplicationRecord
 
   # Scopes
   scope :not_archived, -> { where('`search_endpoints`.`archived` = false') }
-  
+
   # rubocop:disable Layout/LineLength
   scope :for_user_via_teams, ->(user) {
     joins('
@@ -59,7 +59,7 @@ class SearchEndpoint < ApplicationRecord
     ids = for_user_via_teams(user).distinct.pluck(:id) + for_user_directly_owned(user).distinct.pluck(:id)
     where(id: ids.uniq)
   }
-  
+
   after_initialize do |se|
     se.archived = false if se.archived.nil?
   end
@@ -72,7 +72,7 @@ class SearchEndpoint < ApplicationRecord
   def fullname
     (name.presence || middle_truncate("#{search_engine.capitalize} #{endpoint_url}"))
   end
-  
+
   def mark_archived
     self.archived = true
   end

app/views/api/v1/teams/_team.json.jbuilder

@@ -28,7 +28,8 @@ unless for_sharing
   end
 
   json.search_endpoints do
-    json.array! team.search_endpoints.not_archived, partial: 'api/v1/search_endpoints/search_endpoint', as: :search_endpoint
+    json.array! team.search_endpoints.not_archived, partial: 'api/v1/search_endpoints/search_endpoint',
+                                                    as:      :search_endpoint
   end
   json.owner do
     json.id             team.owner.id

app/views/search_endpoints/_search_endpoint.json.jbuilder

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
-json.extract! search_endpoint, :id, :name, :endpoint_url, :search_engine, :custom_headers, :api_method, :archived, :created_at,
-              :updated_at
+json.extract! search_endpoint, :id, :name, :endpoint_url, :search_engine, :custom_headers, :api_method, :archived,
+              :created_at, :updated_at
 json.url search_endpoint_url(search_endpoint, format: :json)