Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor search engine into own endpoint #788

Merged
merged 125 commits into from
Oct 16, 2023

Conversation

epugh
Copy link
Member

@epugh epugh commented Aug 17, 2023

Description

Every try contains all of the data about the search engine. This introduces an actual search_endpoint object that you can pick from.

Motivation and Context

Every try drags along a copy of all the search engine end points. We attempt to give them names, like ES 1 or Solr 2 but that's buggy, and not very meaningful to users. Likewise, in a lot of places we show super long urls, like you might see on a cloud hosted version of your search engine, and htose are illegiable. We want to give names to them that are human friendly!

Lastly, in lots of places an Admin type will set up the connection for use by the relevance folks, and maybe we want to introduce some usernames etc? Also give us room to add NEW types of search engines with specific needs.

How Has This Been Tested?

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@epugh epugh temporarily deployed to quepid-pr-788 October 4, 2023 02:40 Inactive
@epugh epugh temporarily deployed to quepid-pr-788 October 4, 2023 21:28 Inactive
@epugh
Copy link
Member Author

epugh commented Oct 5, 2023

  • Need to test that we assign a search endpoint to a team when a case is shared with a team in the migration.

@epugh epugh temporarily deployed to quepid-pr-788 October 5, 2023 02:16 Inactive
@epugh epugh temporarily deployed to quepid-pr-788 October 5, 2023 02:39 Inactive
@epugh epugh temporarily deployed to quepid-pr-788 October 16, 2023 20:37 Inactive
@epugh epugh temporarily deployed to quepid-pr-788 October 16, 2023 20:39 Inactive
@epugh epugh merged commit 34beb16 into main Oct 16, 2023
2 of 4 checks passed
@epugh epugh linked an issue Nov 2, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant