Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub workflows to trigger on pull_request_target so that they can run on PRs from public forks #173

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

tyiu
Copy link
Contributor

@tyiu tyiu commented Jul 19, 2024

As an example, I could not properly merge #171 because the workflows were not running. I had to temporarily remove the merge restrictions to move ahead.

@tyiu tyiu requested a review from bryanmontz July 19, 2024 12:44
@@ -1,7 +1,7 @@
name: SwiftLint

on:
push:
pull_request_target:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyiu tyiu force-pushed the tyiu/github-workflow-pr-target branch from cd41e79 to 43c4d6e Compare July 19, 2024 12:48
@tyiu tyiu changed the title Fix GitHub workflows to trigger on pull_request_target instead of push so that they can run on PRs from public forks Fix GitHub workflows to trigger on pull_request_target so that they can run on PRs from public forks Jul 19, 2024
@bryanmontz bryanmontz merged commit 21c46c5 into main Aug 1, 2024
4 checks passed
@bryanmontz bryanmontz deleted the tyiu/github-workflow-pr-target branch August 1, 2024 11:13
RandyMcMillan pushed a commit to RandyMcMillan/nostr-sdk-ios that referenced this pull request Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants