Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MetadataCoding.swift #171

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Update MetadataCoding.swift #171

merged 1 commit into from
Jul 18, 2024

Conversation

PavleKreator
Copy link
Contributor

Add a public init method to the structure, since auto-generated one is internal by default.

All public structs need to have public inits so that other users of the SDK can instantiate it.

Add a public init method to the structure, since auto-generated one is internal by default.

All public structs need to have public inits so that other users of the SDK can instantiate it.
Copy link
Contributor

@tyiu tyiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution.

@tyiu
Copy link
Contributor

tyiu commented Jul 17, 2024

Not sure why the GitHub workflow CI isn't running. I'm going to try closing the PR and reopening again to see if that does anything.

@tyiu tyiu closed this Jul 17, 2024
@tyiu tyiu reopened this Jul 17, 2024
@tyiu tyiu closed this Jul 17, 2024
@tyiu tyiu reopened this Jul 17, 2024
@tyiu tyiu merged commit e555470 into nostr-sdk:main Jul 18, 2024
@tyiu
Copy link
Contributor

tyiu commented Jul 18, 2024

Temporarily lifted status check requirement to merge. I'll figure out what happened later.

RandyMcMillan pushed a commit to RandyMcMillan/nostr-sdk-ios that referenced this pull request Sep 1, 2024
Add a public init method to the structure, since auto-generated one is internal by default.

All public structs need to have public inits so that other users of the SDK can instantiate it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants