assert,util: change WeakMap and WeakSet comparison handling #53495

synapse · 2024-06-18T06:26:58Z

Fixes #18227

As discussed in the task I've added :

a check if the compared params are either WeakSet or WeakMap and compare their instance
I slightly updated the doc to reflect this change
added tests for Weak* instances comparison

BridgeAR

Thank you for picking this up!
Time has passed and I agree by now that this behavior is better.

+1 with my suggestions

lib/internal/util/comparisons.js

mcollina

lgtm

BridgeAR

LGTM % comments

test/parallel/test-assert-deep.js

lib/internal/util/comparisons.js

test/parallel/test-assert-deep.js

BridgeAR

LGTM, thanks for the fast following up on the suggestions!

BridgeAR · 2024-06-18T13:19:51Z

@synapse just a small nit that does not have to be followed up upon:

We have a commit message rule about adding the subsystem to each commit. In this specific case it could e.g., look like: assert,util: change WeakMap and WeakSet comparison handling

nodejs-github-bot · 2024-06-18T13:20:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59862/

nodejs-github-bot · 2024-06-18T14:43:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59865/

nodejs-github-bot · 2024-06-18T16:37:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59868/

nodejs-github-bot · 2024-06-19T07:05:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59878/

nodejs-github-bot · 2024-06-19T21:12:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59897/

nodejs-github-bot · 2024-06-20T07:53:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59901/

nodejs-github-bot · 2024-06-23T00:49:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59934/

nodejs-github-bot · 2024-06-24T07:52:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59947/

nodejs-github-bot · 2024-06-25T13:43:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59964/

nodejs-github-bot · 2024-06-26T15:36:44Z

Commit Queue failed

- Loading data for nodejs/node/pull/53495
✔  Done loading data for nodejs/node/pull/53495
----------------------------------- PR info ------------------------------------
Title      assert,util: change WeakMap and WeakSet comparison handling (#53495)
Author     Cristian Barlutiu  (@synapse, first-time contributor)
Branch     synapse:weak-handle -> nodejs:main
Labels     assert, util, semver-major, author ready, commit-queue-rebase
Commits    1
 - assert,util: change WeakMap and WeakSet comparison handling
Committers 1
 - Cristian Barlutiu 
PR-URL: https://github.com/nodejs/node/pull/53495
Reviewed-By: Matteo Collina 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Moshe Atlow 
Reviewed-By: Luigi Pinca 
Reviewed-By: Minwoo Jung 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53495
Reviewed-By: Matteo Collina 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Moshe Atlow 
Reviewed-By: Luigi Pinca 
Reviewed-By: Minwoo Jung 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 18 Jun 2024 06:26:58 GMT
   ✔  Approvals: 7
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53495#pullrequestreview-2125017937
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/53495#pullrequestreview-2125500391
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53495#pullrequestreview-2127119543
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53495#pullrequestreview-2129045696
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53495#pullrequestreview-2129451730
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53495#pullrequestreview-2133314585
   ✔  - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/53495#pullrequestreview-2133810643
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2024-06-25T13:43:09Z: https://ci.nodejs.org/job/node-test-pull-request/59964/
- Querying data for job/node-test-pull-request/59964/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/9682614533

BridgeAR · 2024-06-26T15:52:03Z

Does anyone know why fedora always fails? I will start the CI again.

nodejs-github-bot · 2024-06-26T15:52:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59981/

nodejs-github-bot · 2024-06-27T21:54:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59998/

mcollina

lgtm

nodejs-github-bot · 2024-06-28T07:28:57Z

Landed in 9cd9aa8...764b13d

PR-URL: #53495 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020 PR-URL: TBD

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020 PR-URL: #55338

nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jun 18, 2024

synapse force-pushed the weak-handle branch from 749daee to d1bdc2b Compare June 18, 2024 06:27

BridgeAR reviewed Jun 18, 2024

View reviewed changes

lib/internal/util/comparisons.js Outdated Show resolved Hide resolved

lib/internal/util/comparisons.js Outdated Show resolved Hide resolved

mcollina approved these changes Jun 18, 2024

View reviewed changes

synapse force-pushed the weak-handle branch from d1bdc2b to 69bd695 Compare June 18, 2024 09:42

BridgeAR approved these changes Jun 18, 2024

View reviewed changes

yosuke-furukawa mentioned this pull request Jun 18, 2024

util.isDeepStrictEqual would be better to return false to compare WeakMap/WeakSet #18227

Closed

tniessen added the assert Issues and PRs related to the assert subsystem. label Jun 18, 2024

synapse force-pushed the weak-handle branch from 00f9d96 to c770541 Compare June 18, 2024 12:36

BridgeAR approved these changes Jun 18, 2024

View reviewed changes

BridgeAR added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2024

BridgeAR added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jun 18, 2024

assert,util: change WeakMap and WeakSet comparison handling

163ef7c

synapse force-pushed the weak-handle branch from c770541 to 163ef7c Compare June 18, 2024 13:53

BridgeAR added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2024

tniessen changed the title ~~Fix: WeakMap and WeakSet comparison handling~~ assert,util: change WeakMap and WeakSet comparison handling Jun 18, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2024

jasnell approved these changes Jun 19, 2024

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 19, 2024

benjamingr approved these changes Jun 19, 2024

View reviewed changes

MoLow approved these changes Jun 20, 2024

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2024

mcollina removed the needs-ci PRs that need a full CI run. label Jun 20, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2024

lpinca approved these changes Jun 21, 2024

View reviewed changes

JungMinu approved these changes Jun 22, 2024

View reviewed changes

BridgeAR added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jun 26, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 26, 2024

mcollina approved these changes Jun 28, 2024

View reviewed changes

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 28, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 28, 2024

nodejs-github-bot closed this Jun 28, 2024

ljharb mentioned this pull request Sep 6, 2024

breaking change in node 23 inspect-js/node-deep-equal#110

Open

RafaelGSS mentioned this pull request Oct 9, 2024

2024-10-15, Version 23.0.0 (Current) #55338

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

assert,util: change WeakMap and WeakSet comparison handling #53495

assert,util: change WeakMap and WeakSet comparison handling #53495

synapse commented Jun 18, 2024 •

edited

Loading

BridgeAR left a comment

mcollina left a comment

BridgeAR left a comment

BridgeAR left a comment

BridgeAR commented Jun 18, 2024

nodejs-github-bot commented Jun 18, 2024

nodejs-github-bot commented Jun 18, 2024

nodejs-github-bot commented Jun 18, 2024

nodejs-github-bot commented Jun 19, 2024

nodejs-github-bot commented Jun 19, 2024

nodejs-github-bot commented Jun 20, 2024

nodejs-github-bot commented Jun 23, 2024

nodejs-github-bot commented Jun 24, 2024

nodejs-github-bot commented Jun 25, 2024

nodejs-github-bot commented Jun 26, 2024

BridgeAR commented Jun 26, 2024

nodejs-github-bot commented Jun 26, 2024

nodejs-github-bot commented Jun 27, 2024

mcollina left a comment

nodejs-github-bot commented Jun 28, 2024

assert,util: change WeakMap and WeakSet comparison handling #53495

assert,util: change WeakMap and WeakSet comparison handling #53495

Conversation

synapse commented Jun 18, 2024 • edited Loading

BridgeAR left a comment

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

BridgeAR left a comment

Choose a reason for hiding this comment

BridgeAR left a comment

Choose a reason for hiding this comment

BridgeAR commented Jun 18, 2024

nodejs-github-bot commented Jun 18, 2024

nodejs-github-bot commented Jun 18, 2024

nodejs-github-bot commented Jun 18, 2024

nodejs-github-bot commented Jun 19, 2024

nodejs-github-bot commented Jun 19, 2024

nodejs-github-bot commented Jun 20, 2024

nodejs-github-bot commented Jun 23, 2024

nodejs-github-bot commented Jun 24, 2024

nodejs-github-bot commented Jun 25, 2024

nodejs-github-bot commented Jun 26, 2024

BridgeAR commented Jun 26, 2024

nodejs-github-bot commented Jun 26, 2024

nodejs-github-bot commented Jun 27, 2024

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Jun 28, 2024

synapse commented Jun 18, 2024 •

edited

Loading