Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlib: set zlib.bytesRead end-of-life #55020

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

zlib: set zlib.bytesRead end-of-life #55020

wants to merge 1 commit into from
+4 −124

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Sep 19, 2024

Let's set zlib.bytesRead to end-of-life which has been runtime deprecated since v11.

cc @nodejs/tsc

@anonrig anonrig added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 19, 2024
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem. labels Sep 19, 2024
@anonrig anonrig force-pushed the runtime-deprecate-zlib-bytes-read branch from fc83cd8 to 34c1d02 Compare September 19, 2024 20:01
@RedYetiDev RedYetiDev added the deprecations Issues and PRs related to deprecations. label Sep 19, 2024
@benjamingr
Copy link
Member

You forgot to delete the relevant part from the test :)

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (291d90a) to head (7aaea82).
Report is 39 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55020      +/-   ##
==========================================
+ Coverage   88.04%   88.23%   +0.19%     
==========================================
  Files         652      652              
  Lines      183764   183875     +111     
  Branches    35862    35858       -4     
==========================================
+ Hits       161787   162238     +451     
+ Misses      15233    14907     -326     
+ Partials     6744     6730      -14
Files with missing lines Coverage Δ
lib/zlib.js 98.46% <ø> (+0.05%) ⬆️

... and 89 files with indirect coverage changes

mcollina
mcollina approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig anonrig force-pushed the runtime-deprecate-zlib-bytes-read branch from 34c1d02 to 7aaea82 Compare September 21, 2024 16:29
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62647/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anonrig @benjamingr @nodejs-github-bot @mcollina @jasnell @RedYetiDev