Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: do not cache NumberOfHeapSpaces() globally #20971

Closed
wants to merge 2 commits into from
Closed

src: do not cache NumberOfHeapSpaces() globally #20971

wants to merge 2 commits into from

Commits on May 25, 2018

  1. src: do not cache NumberOfHeapSpaces() globally 

    While `NumberOfHeapSpaces()` currently returns a constant value,
that is not strictly guaranteed by the V8 API as far as I can tell.
Therefore, caching it globally does not seem appropriate.

(The motivation here is that this squelches warnings which are
produced by concurrency debugging tooling due to the apparent
race conditions when accessing the global variable.)
    @addaleax
    addaleax committed May 25, 2018
    Configuration menu
    Copy the full SHA
    0df7dec View commit details
    Browse the repository at this point in the history

Commits on May 26, 2018

  1. [squash] bnoordhuis suggestion

    @addaleax
    addaleax authored May 26, 2018
    Configuration menu
    Copy the full SHA
    f26c89c View commit details
    Browse the repository at this point in the history