src: do not cache NumberOfHeapSpaces() globally
#20971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `NumberOfHeapSpaces()` currently returns a constant value, that is not strictly guaranteed by the V8 API as far as I can tell. Therefore, caching it globally does not seem appropriate. (The motivation here is that this squelches warnings which are produced by concurrency debugging tooling due to the apparent race conditions when accessing the global variable.)
nodejs-github-bot
added
c++
TimothyGu
approved these changes
May 26, 2018
JungMinu
approved these changes
May 26, 2018
bnoordhuis
approved these changes
May 26, 2018
src/node_v8.cc
Outdated
| @@ -101,7 +98,7 @@ void UpdateHeapSpaceStatisticsBuffer(const FunctionCallbackInfo<Value>& args) { | |||
| Isolate* const isolate = env->isolate(); | |||
| double* buffer = env->heap_space_statistics_buffer(); | |||
|
|
|||
| for (size_t i = 0; i < number_of_heap_spaces; i++) { | |||
| for (size_t i = 0; i < isolate->NumberOfHeapSpaces(); i++) { | |||
There was a problem hiding this comment.
Suggestion: cache the value in a local so it's only one function call instead of n function calls.
joyeecheung
approved these changes
May 26, 2018
BridgeAR
added
the
author ready
jasnell
approved these changes
May 29, 2018
|
Landed in e1df688 |
addaleax
added a commit
that referenced
this pull request
Jun 1, 2018
While `NumberOfHeapSpaces()` currently returns a constant value, that is not strictly guaranteed by the V8 API as far as I can tell. Therefore, caching it globally does not seem appropriate. (The motivation here is that this squelches warnings which are produced by concurrency debugging tooling due to the apparent race conditions when accessing the global variable.) PR-URL: #20971 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 6, 2018
While `NumberOfHeapSpaces()` currently returns a constant value, that is not strictly guaranteed by the V8 API as far as I can tell. Therefore, caching it globally does not seem appropriate. (The motivation here is that this squelches warnings which are produced by concurrency debugging tooling due to the apparent race conditions when accessing the global variable.) PR-URL: #20971 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
NumberOfHeapSpaces()currently returns a constant value,that is not strictly guaranteed by the V8 API as far as I can tell.
Therefore, caching it globally does not seem appropriate.
(The motivation here is that this squelches warnings which are
produced by concurrency debugging tooling due to the apparent
race conditions when accessing the global variable.)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes (presumably)