Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build,test: make building addon tests less fragile" - broken source tarballs #18287

Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "build,test: make building addon tests less fragile"
This reverts commit d9b59de.

Breaks downloadable source tarball builds as we remove some files prior
to creating a tarball but those files are included in the comprehensive
list of dependencies listed in .deps.
  • Loading branch information
rvagg committed Jan 24, 2018
commit a6051eb589e26a5e6f34dd325327dc08ab9d24af
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ ipch/
/npm.wxs
/tools/msvs/npm.wixobj
/tools/msvs/genfiles/
/test/addons/??_*/
email.md
deps/v8-*
deps/icu
Expand Down
Loading