Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "build,test: make building addon tests less fragile" - broken source tarballs #18287

Closed
wants to merge 4 commits into from
Closed

Revert "build,test: make building addon tests less fragile" - broken source tarballs #18287

wants to merge 4 commits into from

Commits on Jan 24, 2018

  1. Revert "build,tools: check freshness of doc addons" 

    This reverts commit 2cb9e2a.

Reverted along with d9b59de as this introduces freshness checks that
are too stringent without the comprehensive dependency checking of
introduced in d9b59de so `make test` won't work with this.
    @rvagg
    rvagg committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    4d705e6 View commit details
    Browse the repository at this point in the history

  2. Revert "build,test: make building addon tests less fragile" 

    This reverts commit d9b59de.

Breaks downloadable source tarball builds as we remove some files prior
to creating a tarball but those files are included in the comprehensive
list of dependencies listed in .deps.
    @rvagg
    rvagg committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    a6051eb View commit details
    Browse the repository at this point in the history

  3. Revert "tools: simplify tools/doc/addon-verify.js" 

    This reverts commit c668263.

Reverted along with d9b59de as this breaks compilation from
downloadable source tarballs.
    @rvagg
    rvagg committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    9134772 View commit details
    Browse the repository at this point in the history

  4. Revert "tools: teach gyp to write an 'all deps' rule" 

    This reverts commit 920c132.

Reverted along with d9b59de as this breaks compilation from
downloadable source tarballs.
    @rvagg
    rvagg committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    cd9fd23 View commit details
    Browse the repository at this point in the history