mustParseBool should return false for empty string #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
previously approved these changes
Jul 10, 2017
harshavardhana
previously approved these changes
Jul 10, 2017
nitisht
approved these changes
Jul 11, 2017
|
@deekoder don't merge this yet, there is a small change that I wish to do this PR. |
I.e, ENABLE_HTTPS environment variable is not set
`mustParseBool(os.Getenv("ENABLE_HTTPS"))` should be `false`
krisis
commented
Jul 11, 2017
| @@ -124,7 +124,7 @@ func testMakeBucketError() { | |||
| mustParseBool(os.Getenv(enableHTTPS)), | |||
| ) | |||
| if err != nil { | |||
| log.Fatalf("Error:", err) | |||
| log.Fatalf("Error: %s", err) | |||
There was a problem hiding this comment.
This was spotted by my editor.
| @@ -3917,7 +3917,7 @@ func testFunctionalV2() { | |||
| } | |||
| } | |||
|
|
|||
| // Convert string to bool and always return true if any error | |||
| // Convert string to bool and always return false if any error | |||
There was a problem hiding this comment.
minor nit fixed, not originally part of this PR
|
@deekoder This PR can now be merged subject to reviewers' approval. |
harshavardhana
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e, ENABLE_HTTPS environment variable is not set
mustParseBool(os.Getenv("ENABLE_HTTPS"))should befalseFixes #751