Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mustParseBool should default to false when string is empty #751

Closed
krisis opened this issue Jul 10, 2017 · 1 comment
Closed

mustParseBool should default to false when string is empty #751

krisis opened this issue Jul 10, 2017 · 1 comment

Comments

@krisis
Copy link
Member

krisis commented Jul 10, 2017

mustParseBool is a utility function that parses boolean value set in an shell environment variable. Most *nix shell programs leave environment variables unset to indicate false. So, mustParseBool should default to false when an empty string is passed.
E.g, If ENABLE_HTTPS environment variable is not set mustParseBool(os.Getenv("ENABLE_HTTPS")) should be false.

@vadmeste
Copy link
Member

E.g, ENABLE_HTTPS environment variable is not set mustParseBool(os.Getenv("ENABLE_HTTPS")) should be false.

I agree since this is only for testing..

@deekoder deekoder added this to the Current milestone Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants