Offset terminal when inline chat appears to ensure cursor is visible #210239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will overlay the terminal inline chat widget on top of the terminal the same as previously where the cursor would be visible. If it would not be visible, the terminal wrapper element is now shifted upwards to ensure it's visible. This comes with a couple of downsides: - The very top of the terminal cannot be accessed as overflow is clipped by the view. - The chat may overlap content if there is any below the cursor, which is an unlikely edge case. This isn't as good as a zone widget-like system in xterm.js could be, but that is quite the undertaking and complicates the renderer code quite a bit. So this is a good compromise. Fixes #4720
meganrogge
reviewed
Apr 12, 2024
Comment on lines
+63
to
+69
| hideLock() { | ||
| this._overlay.value?.lockHide(); | ||
| } | ||
|
|
||
| hideUnlock() { | ||
| this._overlay.value?.unlockHide(); | ||
| } |
There was a problem hiding this comment.
this terminology is a bit confusing ... could it just be lock and unlock? vs hideLock and hideUnlock
There was a problem hiding this comment.
Lock and unlock by themselves seem like they'd be related to positioning. Also it has another hide mechanism that this overrides
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will overlay the terminal inline chat widget on top of the terminal the same as previously where the cursor would be visible. If it would not be visible, the terminal wrapper element is now shifted upwards to ensure it's visible. This comes with a couple of downsides:
This isn't as good as a zone widget-like system in xterm.js could be, but that is quite the undertaking and complicates the renderer code quite a bit. So this is a good compromise.
Fixes microsoft/vscode-copilot#4720