-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autodetect indentSize takes template literal into account #4720
Comments
I think the feature request label is appropriate for now... The indentation detection code is language agnostic, so it just looks at the file contents (not at the tokens). If we ever change that code to first tokenize the file and then guess, I agree that lines in multiline strings and lines in multiline comments should be omitted from the detection. |
👍 |
To keep the number of issues in our inbox at a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: we look at the number of votes the issue has received and the number of duplicate issues filed. Thank you for your time and understanding. P.S. If you disagree and feel that this issue is crucial: we're happy to listen and to reconsider. |
This will overlay the terminal inline chat widget on top of the terminal the same as previously where the cursor would be visible. If it would not be visible, the terminal wrapper element is now shifted upwards to ensure it's visible. This comes with a couple of downsides: - The very top of the terminal cannot be accessed as overflow is clipped by the view. - The chat may overlap content if there is any below the cursor, which is an unlikely edge case. This isn't as good as a zone widget-like system in xterm.js could be, but that is quite the undertaking and complicates the renderer code quite a bit. So this is a good compromise. Fixes #4720
Steps to Reproduce:
editor.tabSize
is set toauto
test.js
with the following contentsAs you can see, it sets the
tabSize
to2
because it is2
in the multiline template literal. But it shouldn't take strings into account to determine this.// @alexandrudima
The text was updated successfully, but these errors were encountered: