Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement client side uwb simulator event trigger #175

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

Allow the uwb cli tool to trigger session events.

Technical Details

  • Implement IOCTL_UWB_DEVICE_SIM_TRIGGER_SESSION_EVENT simulator DDI in UwbDeviceSimulatorConnector.
  • Expose TriggerSessionEvent from UwbDeviceSimulator.
  • Add trigger sub-command to uwbsim.exe cli tool.

Test Results

  • Ran nocli.exe uwb range --SessionId 1234 start --DeviceRole 1 --MultiNodeMode 0 --NumberOfControlees 1 --DeviceMacAddress 12:34 --DestinationMacAddress 67:89 --DeviceType 1 in one instance, and uwbsim.exe trigger --sessionId 1234 -e 1 in another instance and observed the driver toggle random measurement generation.

Reviewer Focus

None

Future Work

The driver currently session-event information in file-specific state, which means it is lost when the associated file handle is closed. This state should instead be stored in the UwbSimulatorSession object.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 28, 2023 15:03
@abeltrano abeltrano merged commit d4f9420 into develop Mar 28, 2023
@abeltrano abeltrano deleted the simtrigger2 branch March 28, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants