Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate @fluentui/react-motion-preview #32190

Merged
merged 2 commits into from
Aug 7, 2024
Merged

chore: deprecate @fluentui/react-motion-preview #32190

merged 2 commits into from
Aug 7, 2024

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Aug 1, 2024 •
edited
Loading

New Behavior

  • Files for @fluentui/react-motion-preview are removed
  • Once the PR will be merged, I will deprecate the package on NPM, too

Related Issue(s)

Fixes #30698.

@github-actions github-actions bot added this to the August Project Cycle Q3 2024 milestone Aug 1, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 1, 2024 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 1, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender-with-unmount 73 80 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 642 623 5000
Button mount 293 320 5000
Field mount 1156 1112 5000
FluentProvider mount 710 721 5000
FluentProviderWithTheme mount 80 92 10
FluentProviderWithTheme virtual-rerender 36 32 10
FluentProviderWithTheme virtual-rerender-with-unmount 73 80 10 Possible regression
MakeStyles mount 862 848 50000
Persona mount 1774 1758 5000
SpinButton mount 1384 1406 5000
SwatchPicker mount 1628 1648 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 1, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 1, 2024 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 1, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AccordionMinimalPerf.default 77 87 0.89:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 99 86 1.15:1
FlexMinimalPerf.default 170 151 1.13:1
ChatDuplicateMessagesPerf.default 166 149 1.11:1
SegmentMinimalPerf.default 207 190 1.09:1
DropdownManyItemsPerf.default 413 382 1.08:1
GridMinimalPerf.default 199 186 1.07:1
LoaderMinimalPerf.default 195 182 1.07:1
RosterPerf.default 1646 1539 1.07:1
RefMinimalPerf.default 115 107 1.07:1
LayoutMinimalPerf.default 205 194 1.06:1
ButtonSlotsPerf.default 327 312 1.05:1
ListNestedPerf.default 335 319 1.05:1
StatusMinimalPerf.default 403 384 1.05:1
ChatWithPopoverPerf.default 206 198 1.04:1
AlertMinimalPerf.default 156 151 1.03:1
ChatMinimalPerf.default 458 445 1.03:1
CheckboxMinimalPerf.default 1187 1154 1.03:1
HeaderSlotsPerf.default 459 447 1.03:1
TableManyItemsPerf.default 1143 1113 1.03:1
VideoMinimalPerf.default 451 438 1.03:1
CardMinimalPerf.default 311 304 1.02:1
DatepickerMinimalPerf.default 3692 3622 1.02:1
PopupMinimalPerf.default 365 357 1.02:1
ProviderMergeThemesPerf.default 683 671 1.02:1
ProviderMinimalPerf.default 208 204 1.02:1
TextAreaMinimalPerf.default 287 281 1.02:1
TreeWith60ListItems.default 91 89 1.02:1
AnimationMinimalPerf.default 299 296 1.01:1
BoxMinimalPerf.default 199 197 1.01:1
ButtonMinimalPerf.default 92 91 1.01:1
ButtonOverridesMissPerf.default 656 648 1.01:1
DialogMinimalPerf.default 451 446 1.01:1
HeaderMinimalPerf.default 201 199 1.01:1
ItemLayoutMinimalPerf.default 709 699 1.01:1
ListCommonPerf.default 403 399 1.01:1
MenuButtonMinimalPerf.default 990 976 1.01:1
IconMinimalPerf.default 386 384 1.01:1
TableMinimalPerf.default 243 241 1.01:1
CustomToolbarPrototype.default 1497 1484 1.01:1
ToolbarMinimalPerf.default 555 548 1.01:1
CarouselMinimalPerf.default 259 260 1:1
DropdownMinimalPerf.default 1445 1443 1:1
EmbedMinimalPerf.default 1897 1903 1:1
FormMinimalPerf.default 224 225 1:1
ReactionMinimalPerf.default 220 219 1:1
AttachmentMinimalPerf.default 81 82 0.99:1
AttachmentSlotsPerf.default 664 669 0.99:1
RadioGroupMinimalPerf.default 261 264 0.99:1
SplitButtonMinimalPerf.default 2289 2302 0.99:1
TextMinimalPerf.default 200 202 0.99:1
InputMinimalPerf.default 522 533 0.98:1
LabelMinimalPerf.default 218 224 0.97:1
ListMinimalPerf.default 303 312 0.97:1
ListWith60ListItems.default 365 376 0.97:1
TreeMinimalPerf.default 482 495 0.97:1
SkeletonMinimalPerf.default 202 210 0.96:1
TooltipMinimalPerf.default 1279 1328 0.96:1
DividerMinimalPerf.default 201 211 0.95:1
MenuMinimalPerf.default 503 528 0.95:1
SliderMinimalPerf.default 715 750 0.95:1
AvatarMinimalPerf.default 103 111 0.93:1
ImageMinimalPerf.default 215 234 0.92:1

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 1, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 1, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 622 623 5000
Breadcrumb mount 1683 1733 1000
Checkbox mount 1715 1678 5000
CheckboxBase mount 1471 1495 5000
ChoiceGroup mount 2951 2966 5000
ComboBox mount 691 704 1000
CommandBar mount 6590 6574 1000
ContextualMenu mount 12261 12191 1000
DefaultButton mount 789 784 5000
DetailsRow mount 2277 2270 5000
DetailsRowFast mount 2241 2224 5000
DetailsRowNoStyles mount 2059 2029 5000
Dialog mount undefined err 1000
DocumentCardTitle mount 221 224 1000
Dropdown mount 1984 1996 5000
FocusTrapZone mount 1157 1142 5000
FocusZone mount 1098 1129 5000
GroupedList mount 42134 42086 2
GroupedList virtual-rerender 20136 20202 2
GroupedList virtual-rerender-with-unmount 51544 51899 2
GroupedListV2 mount 221 235 2
GroupedListV2 virtual-rerender 210 215 2
GroupedListV2 virtual-rerender-with-unmount 237 223 2
IconButton mount 1145 1164 5000
Label mount 343 341 5000
Layer mount 2738 2746 5000
Link mount 402 399 5000
MenuButton mount 988 997 5000
MessageBar mount 21540 21496 5000
Nav mount 2046 2049 1000
OverflowSet mount 774 796 5000
Panel mount 1859 1830 1000
Persona mount 788 743 1000
Pivot mount 916 897 1000
PrimaryButton mount 926 911 5000
Rating mount 4760 4686 5000
SearchBox mount 918 919 5000
Shimmer mount 1888 1871 5000
Slider mount 1343 1319 5000
SpinButton mount 2924 2980 5000
Spinner mount 388 386 5000
SplitButton mount 1902 1852 5000
Stack mount 430 422 5000
StackWithIntrinsicChildren mount 875 865 5000
StackWithTextChildren mount 2772 2720 5000
SwatchColorPicker mount 6436 6346 5000
TagPicker mount 1470 1426 5000
Text mount 387 384 5000
TextField mount 971 955 5000
ThemeProvider mount 852 859 5000
ThemeProvider virtual-rerender 572 594 5000
ThemeProvider virtual-rerender-with-unmount 1305 1315 5000
Toggle mount 599 620 5000
buttonNative mount 194 194 5000

@layershifter layershifter marked this pull request as ready for review August 1, 2024 16:38
@Hotell
Copy link
Contributor

Hotell commented Aug 5, 2024

Once the PR will be merged, I will deprecate the package on NPM, too

wondering how are you gonna do that as we don't have this setup within our releases. I'd suggest to add the package to this issue so once we have the infra we will do it for all packages

#30541

@layershifter
Copy link
Member Author

wondering how are you gonna do that as we don't have this setup within our releases.

@Hotell by CLI npm deprecate... 🐱

@layershifter layershifter merged commit fc76da9 into microsoft:master Aug 7, 2024
21 checks passed
@layershifter layershifter deleted the chore/deprecate-pkg branch August 7, 2024 10:31
@layershifter
Copy link
Member Author

image

marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 7, 2024
@marcosmoura
Merge branch 'master' into rfc/z-index-handling
5b96ef9 
* master: (48 commits)
  chore: migrate to storybook v7 (microsoft#32018)
  release: applying package updates - react-components
  ci: make public-docsite-v9 deploy pipeline work and make it faster (microsoft#32248)
  fix(Toolbar): hardcode size of `ToolbarButton` (microsoft#32185)
  chore: deprecate @fluentui/react-motion-preview (microsoft#32190)
  release: applying package updates - web-components
  docs: add wrapping menu item example to ContextualMenu docs (microsoft#31289)
  docs: update title of v8 keyboard-accessible drag & drop example, add docs (microsoft#32216)
  release: applying package updates - react-components
  fix: Card does not override specified focusMode based on event listeners (microsoft#32200)
  Fix undefined reference in older browsers in useMessageBarReflow (microsoft#32238)
  feat: Add transparent appearance to ToolbarButton (microsoft#32205)
  fix(react-tabs): ignore ref for tab reserved space content slot (microsoft#31775)
  fix(Dialog): do not require ref forwarding (microsoft#32095)
  feat: add verify-packaging to react v8 release pipeline (microsoft#32212)
  chore(web-components): remove type-check definition and follow repo target defaults for consistency and type-check speeds (microsoft#32208)
  chore(react-tree): improve ImmutableSet and ImmutableMap internal implementation (microsoft#32167)
  release: applying package updates - web-components
  feat(web-components): add tablist (microsoft#32098)
  release: applying package updates - react-components
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@Hotell Hotell Hotell approved these changes

@JustSlone JustSlone JustSlone approved these changes

@marcosmoura marcosmoura Awaiting requested review from marcosmoura

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar is a code owner

@tudorpopams tudorpopams Awaiting requested review from tudorpopams tudorpopams is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
August Project Cycle Q3 2024
Development

Successfully merging this pull request may close these issues.

[chore]: deprecate @fluentui/react-motion-preview
4 participants
@layershifter @fabricteam @Hotell @JustSlone