-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Dialog): do not require ref forwarding #32095
Merged
layershifter
merged 1 commit into
microsoft:master
from
layershifter:feat/motion-ref-forwarder
Aug 6, 2024
Merged
fix(Dialog): do not require ref forwarding #32095
layershifter
merged 1 commit into
microsoft:master
from
layershifter:feat/motion-ref-forwarder
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
feat/motion-ref-forwarder
branch
from
July 24, 2024 14:06
62abdd9
to
ea3d7ff
Compare
📊 Bundle size reportUnchanged fixtures
|
layershifter
force-pushed
the
feat/motion-ref-forwarder
branch
from
July 24, 2024 14:09
ea3d7ff
to
c220d3d
Compare
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 661 | 626 | 5000 | |
Button | mount | 321 | 325 | 5000 | |
Field | mount | 1186 | 1156 | 5000 | |
FluentProvider | mount | 738 | 702 | 5000 | |
FluentProviderWithTheme | mount | 82 | 84 | 10 | |
FluentProviderWithTheme | virtual-rerender | 40 | 36 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 73 | 78 | 10 | |
MakeStyles | mount | 904 | 885 | 50000 | |
Persona | mount | 1791 | 1765 | 5000 | |
SpinButton | mount | 1404 | 1412 | 5000 | |
SwatchPicker | mount | 1718 | 1705 | 5000 |
layershifter
force-pushed
the
feat/motion-ref-forwarder
branch
from
July 24, 2024 14:26
c220d3d
to
c54bcb0
Compare
fabricteam
reviewed
Jul 24, 2024
packages/react-components/react-dialog/library/src/components/Dialog/renderDialog.tsx
Show resolved
Hide resolved
layershifter
force-pushed
the
feat/motion-ref-forwarder
branch
from
August 5, 2024 13:38
c54bcb0
to
7d41f77
Compare
github-actions
bot
modified the milestones:
July Project Cycle Q3 2024,
August Project Cycle Q3 2024
Aug 5, 2024
bsunderhus
approved these changes
Aug 6, 2024
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 7, 2024
* master: (48 commits) chore: migrate to storybook v7 (microsoft#32018) release: applying package updates - react-components ci: make public-docsite-v9 deploy pipeline work and make it faster (microsoft#32248) fix(Toolbar): hardcode size of `ToolbarButton` (microsoft#32185) chore: deprecate @fluentui/react-motion-preview (microsoft#32190) release: applying package updates - web-components docs: add wrapping menu item example to ContextualMenu docs (microsoft#31289) docs: update title of v8 keyboard-accessible drag & drop example, add docs (microsoft#32216) release: applying package updates - react-components fix: Card does not override specified focusMode based on event listeners (microsoft#32200) Fix undefined reference in older browsers in useMessageBarReflow (microsoft#32238) feat: Add transparent appearance to ToolbarButton (microsoft#32205) fix(react-tabs): ignore ref for tab reserved space content slot (microsoft#31775) fix(Dialog): do not require ref forwarding (microsoft#32095) feat: add verify-packaging to react v8 release pipeline (microsoft#32212) chore(web-components): remove type-check definition and follow repo target defaults for consistency and type-check speeds (microsoft#32208) chore(react-tree): improve ImmutableSet and ImmutableMap internal implementation (microsoft#32167) release: applying package updates - web-components feat(web-components): add tablist (microsoft#32098) release: applying package updates - react-components ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
A
ref
will be passed down via context toDialogSurface
rendered byCustomComponent
.Related Issue(s)
Fixes #31808