-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Data diagnostics opt-in #34078
base: main
Are you sure you want to change the base?
Conversation
\azp run |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
src/settings-ui/Settings.UI/SettingsXAML/Views/GeneralPage.xaml
Outdated
Show resolved
Hide resolved
src/settings-ui/Settings.UI/SettingsXAML/Views/GeneralPage.xaml
Outdated
Show resolved
Hide resolved
Existing issue is #964 and we could think about using the existing system gpo instead of creating our own. |
src/settings-ui/Settings.UI/SettingsXAML/OOBE/Views/OobeWhatsNew.xaml.cs
Fixed
Show fixed
Hide fixed
src/settings-ui/Settings.UI/SettingsXAML/OOBE/Views/OobeWhatsNew.xaml.cs
Fixed
Show fixed
Hide fixed
4b1c5c7
to
16f018c
Compare
This comment has been minimized.
This comment has been minimized.
7a9b429
to
726b012
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ea63c1a
to
952311e
Compare
This comment has been minimized.
This comment has been minimized.
952311e
to
4bae874
Compare
This comment has been minimized.
This comment has been minimized.
90e9cbc
to
60cee1d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@stefansjfw
I personally prefer option 1. |
This comment has been minimized.
This comment has been minimized.
@@ -495,6 +495,16 @@ | |||
<decimal value="0" /> | |||
</disabledValue> | |||
</policy> | |||
<policy name="AllowDiagnosticData" class="Both" displayName="$(string.AllowDiagnosticData)" explainText="$(string.AllowDiagnosticDataDescription)" key="Software\Policies\PowerToys" valueName="AllowDataDiagnostics"> | |||
<parentCategory ref="GeneralSettings" /> | |||
<supportedOn ref="SUPPORTED_POWERTOYS_0_84_0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the PR gets not in for the 0.84.0 release please update the supportedOn
value for the next release and do not forget to update the admx version/revision too.
Add ETLConverter Fix AlwaysOnTop
This comment has been minimized.
This comment has been minimized.
…werToys into stefan/opt_in_telem
This comment has been minimized.
This comment has been minimized.
71a7f90
to
23e41f3
Compare
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (13)
Previously acknowledged words that are now absentapplayout appsfolder cswinrt ETW systemsettings SYSTEMWOW USEPOSITION USESIZE 🫥To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the [email protected]:microsoft/PowerToys.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/10909422371/attempts/1' Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (1897) from .github/actions/spell-check/expect.txt and unrecognized words (13)
Consider adding them (in with:
extra_dictionaries:
cspell:r/src/r.txt
cspell:cpp/src/people.txt
cspell:cpp/src/ecosystem.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' Warnings (1)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ℹ️ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed