File Actions menu #31220

Aaron-Junker · 2024-02-01T01:00:36Z

Summary of the Pull Request

Adding a new menu invokable by selecting files in explorer and pressing a shortcut set in the settings.

Screenshots

PR Checklist

Detailed Description of the Pull Request / Additional comments

Things left to do:

Add installer
Add icon
DPI Awareness

Validation Steps Performed

src/modules/previewpane/FileActionsMenu/FileActionsMenu.Ui/MainWindow.xaml

+                    </ui:MenuItem.Icon>
+                </ui:MenuItem>
+                <Separator/>
+                <ui:MenuItem Header="Copy path of files sperated by">


Aaron-Junker · 2024-02-01T10:50:12Z

@niels9001 Do you have an idea why the contextmenu doesn't take the WPFUI style?

…ple tabs

… to replace filename with hash

github-advanced-security

check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

...s/FileActionsMenu/FileActionsMenu.Plugins/PowerToys.FileActionsMenu.Plugins.Hashes/Hashes.cs

Aaron-Junker · 2024-07-21T09:51:31Z

@jaimecbernardo I fixed all your found issues except for the first one (which is dependend on microsoft/microsoft-ui-xaml#3627). So this is ready for round two.

…ActionsMenu

stefansjfw

I did partial review of the code (around 50%). I do another round of review tomorrow. Here are some comments/questions:

I'd prefer not to have dependencies between modules. E.g. FileActionsMenu depending on Peek.Helpers. If possible move Peek.Helpers to Common
"New folder with selection" option creates folder named "New folder with selection" :) If not possible to get to renaming state right away, some other name might be better. maybe just "New Folder ()" as explorer does by default
I don't get Uninstall option for several different apps I tried with. Can you give me an example where it appears so I can give it a try?
Can we move launching PowerToys (ImageResizer, Powerrename, FileLocsmith) out of UI thread so there is no UI freeze until the process is launched)?
Menu is too big on different scaling/rersolution. Can we make it dpi aware? e.g. it appears too big on 100% scaling - 2560x1440
Is CopyImageToClipboard option really needed? That's what OS does by default if I'm not wrong? Is there a scenario where this is additionally useful?

And last but not least, great work Aaron! Great set of tools! Some polishing is needed, but overall, already in a very solid state!

stefansjfw · 2024-08-06T06:58:38Z

Directory.Packages.props

@@ -34,7 +34,9 @@
    <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
    <PackageVersion Include="Microsoft.Extensions.Hosting" Version="8.0.0" />
    <PackageVersion Include="Microsoft.Extensions.Hosting.WindowsServices" Version="8.0.0" />
+    <PackageVersion Include="Microsoft.Security.Extensions" Version="1.3.0" />


Is this needed? FileActionsMenu.Ui builds fine without it

stefansjfw · 2024-08-06T07:10:47Z

Directory.Packages.props

    <PackageVersion Include="Microsoft.Toolkit.Uwp.Notifications" Version="7.1.2" />
+    <PackageVersion Include="Microsoft.UI.Xaml" Version="2.8.6" />


not used anywhere?

stefansjfw · 2024-08-06T07:13:38Z

Directory.Packages.props

@@ -88,7 +91,8 @@
    <PackageVersion Include="UTF.Unknown" Version="2.5.1" />
    <PackageVersion Include="Vanara.PInvoke.User32" Version="3.4.11" />
    <PackageVersion Include="Vanara.PInvoke.Shell32" Version="3.4.11" />
-    <PackageVersion Include="WinUIEx" Version="2.2.0" />
+    <PackageVersion Include="WinUIEx" Version="2.3.4" />
+    <PackageVersion Include="WindowsAPICodePack" Version="7.0.4" />


are we sure it;s safe to use this one?

stefansjfw · 2024-08-06T07:40:15Z

src/common/FilePreviewCommon/FilePreviewCommon.csproj

    </None>
    <None Update="Assets\Monaco\monacoSpecialLanguages.js">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </None>
    <None Update="Assets\Monaco\customTokenColors.js">
      <CopyToOutputDirectory>Always</CopyToOutputDirectory>


any reason this stayed "Always"? Or what's the reason for these changes in this file? These files are small, so performance hit between Always and PreserveNewest is not big

Yes these files are small, but all together they still took some extra seconds everytime I built the project.

stefansjfw · 2024-08-06T07:52:56Z

src/common/GPOWrapperProjection/GPOWrapper.cs

+            return (GpoRuleConfigured)PowerToys.GPOWrapper.GPOWrapper.GetConfiguredFileActionsMenuEnabledValue();
+        }
+
+        public static GpoRuleConfigured GetConfiguredPowerRenameEnabledValue()


:O nice catch!

stefansjfw · 2024-08-06T08:39:54Z

src/modules/FileActionsMenu/FileActionsMenu.Helpers/Extensions.cs

+        /// <exception cref="ArgumentNullException">When <paramref name="value"/> is null.</exception>
+        public static T GetOrArgumentNullException<T>(this T? value)
+        {
+            return value ?? throw new ArgumentNullException(nameof(value));


same here. Is this exception handled anywhere?

stefansjfw · 2024-08-06T09:15:52Z

...enu/FileActionsMenu.Plugins/PowerToys.FileActionsMenu.Plugins.ExecutableActions/Uninstall.cs

+
+        public IAction[]? SubMenuItems => null;
+
+        public int Category => 2;


can we have more descriptive Category values?

stefansjfw · 2024-08-06T09:16:38Z

...enu/FileActionsMenu.Plugins/PowerToys.FileActionsMenu.Plugins.ExecutableActions/Uninstall.cs

+
+        public IconElement? Icon => new FontIcon { Glyph = "\ue74d" };
+
+        public bool IsVisible => SelectedItems.Length == 1


I can't get uninstall action for several different executables. Can you give me an example where it appears?

stefansjfw · 2024-08-06T09:27:49Z

...FileActionsMenu.Plugins/PowerToys.FileActionsMenu.Plugins.FileContentActions/AsXmlEncoded.cs

+
+        public string[] SelectedItems { get => _selectedItems.GetOrArgumentNullException(); set => _selectedItems = value; }
+
+        public string Title => "As for XML encoded string";


stefansjfw · 2024-08-06T09:45:08Z

...enu/FileActionsMenu.Plugins/PowerToys.FileActionsMenu.Plugins.FileProperties/UnblockFiles.cs

+
+        public IconElement? Icon => new FontIcon { Glyph = "\ue785" };
+
+        public bool IsVisible => SelectedItems.Any(file => File.Exists(file + ":Zone.Identifier"));


is Zone.Identifier only related to unblock files? i.e. is it safe to delete every Zone.Identifier file?

Zone.Identifier is an alternative file stream (that's why there's a colon). It is only documented to be used for this feature and doesn't hold any other data.

stefansjfw · 2024-08-06T10:42:20Z

One more comment, we need to align new csproj files here with fd706de and 12098cb

Aaron-Junker · 2024-08-06T10:52:23Z

Thank you for the first review. Your suggestions shouldn't be too hard to implement.

I don't get Uninstall option for several different apps I tried with. Can you give me an example where it appears so I can give it a try?

I know it works for PowerToys and I think for 7-Zip. But I will have to try it again this weekend.

Menu is too big on different scaling/rersolution. Can we make it dpi aware? e.g. it appears too big on 100% scaling - 2560x1440

I thought it is DPI-aware. Can you share a screenshot how big it appears.

Btw it should be in compact mode. When debugging with VS, it sometimes appears bigger as it should be🤷

Is CopyImageToClipboard option really needed? That's what OS does by default if I'm not wrong? Is there a scenario where this is additionally useful?

No, normal behaviour is copying the file object of the image to the clipboard, not the bitmap data. (#5256)

stefansjfw · 2024-08-06T10:56:39Z

This is when running via installer on mentioned resolution

EDIT:

HEre's better screenshot - compared to regular context menu, you see how bigger the items are

stefansjfw · 2024-08-06T11:03:19Z

Thank you for the first review. Your suggestions shouldn't be too hard to implement.

I don't get Uninstall option for several different apps I tried with. Can you give me an example where it appears so I can give it a try?

I know it works for PowerToys and I think for 7-Zip. But I will have to try it again this weekend.

Running installed PT - Crashes when I try to run the menu for 7zip 🤔

Menu is too big on different scaling/rersolution. Can we make it dpi aware? e.g. it appears too big on 100% scaling - 2560x1440

I thought it is DPI-aware. Can you share a screenshot how big it appears.

Btw it should be in compact mode. When debugging with VS, it sometimes appears bigger as it should be🤷

See screenshots in previous comment

Is CopyImageToClipboard option really needed? That's what OS does by default if I'm not wrong? Is there a scenario where this is additionally useful?

No, normal behaviour is copying the file object of the image to the clipboard, not the bitmap data. (#5256)

ok. I saw image on clipboard and though that's it. Thanks

stefansjfw · 2024-08-07T07:41:03Z

/azp run

azure-pipelines · 2024-08-07T07:41:13Z

Azure Pipelines successfully started running 1 pipeline(s).

stefansjfw

did second half of the code review. Comments are mostly minor.

I'd extract what's needed from Peek.Helpers to some Common.Helpers to break dependency between modules. Other than that looks ok.

Once you address current comments I'll do another review. Thank you!

stefansjfw · 2024-08-07T07:49:18Z

...ionsMenu/FileActionsMenu.Plugins/PowerToys.FileActionsMenu.Plugins.MoveCopyActions/SaveAs.cs

+
+            if (dialog.ShowDialog() == DialogResult.OK)
+            {
+                FileActionProgressHelper fileActionProgressHelper = new("Saving file", 1, () => { });


stefansjfw · 2024-08-07T08:06:55Z

src/settings-ui/Settings.UI/ViewModels/FileActionsMenuViewModel.cs

+                {
+                    _fileActionsMenuShortcut = value ?? Settings.Properties.DefaultFileActionsMenuShortcut;
+                    Settings.Properties.FileActionsMenuShortcut = value;
+                    OnPropertyChanged(nameof(FileActionsMenuShortcut));


no need to call OnPropertyChanged. it is called in RaisePropertyChanged

src/settings-ui/Settings.UI/ViewModels/FileActionsMenuViewModel.cs

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw

src/modules/FileActionsMenu/FileActionsMenu/resource.base.h

src/modules/FileActionsMenu/FileActionsMenu/dllmain.cpp

src/modules/FileActionsMenu/FileActionsMenu/Resource.resx

src/modules/FileActionsMenu/FileActionsMenu/FileActionsMenu.base.rc

stefansjfw · 2024-08-07T09:01:30Z

in addition to .csproj needed alignments, there'll be a need for telemetry alignment once #34078 is in

…/microsoft/PowerToys into dev/aaron-junker/FileActionsMenu

htcfreek · 2024-09-12T05:06:27Z

What is required to get this in? Waiting for this.

Aaron-Junker added 4 commits December 24, 2023 00:28

[WIP]Add first draft menu

5ed7d81

[wip]Add Runner project

8fcfb3c

Merge "orgin/main" into "dev/aaron-junker/FileActionsMenu"

bc1214a

[WIP] File Actions Menu

e9b486f

github-advanced-security bot found potential problems Feb 1, 2024

View reviewed changes

Add IAction interface and all actions

d7f7f8d

Aaron-Junker added 20 commits February 1, 2024 16:49

Add move/copy conflict handling and workaround for selection in multi…

47a9d8a

…ple tabs

Add workaround for selecting items in shell folders and libraries

b1a3d5c

Add PowerRename action

8eeee05

Optimazations

42adfee

Added ImageResizer

0b8a64f

Add FileLockmith and move to

65cd1ff

Add Copy Image from Clipboard and to clipboard

fbd07b9

Fix hash generating and allow async execute functions

7daf6d8

Add itemtype property

8b56f1f

Change dialog of hash type to selection in menu and added possibility…

ed475be

… to replace filename with hash

[WIP] Add stubs to compare hashes

a7945d5

Add copy path and uninstall exe

2b05a4f

Allow resolving shortcut when copying path

81358ca

Temp

d6dc8d0

[WIP]

393d3dd

Add file action dialog

5538f48

Moved hashes to plugin

eec2b18

[WIP]Switch to winui3

3ea28de

Switch to WinUi3

fc7c473

Merge main into FileActionsMenu

21f750f

github-advanced-security bot found potential problems Feb 27, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

Fix some errorsin Directory.Packages.Props

aa0ac98

This comment has been minimized.

Sign in to view

Aaron-Junker added 2 commits July 21, 2024 11:38

Add cancel button to conflict dialog

5b8a504

Remove double override warning from save as action

98c6d7d

This comment has been minimized.

Sign in to view

Fix some missing strings

470e948

github-advanced-security bot found potential problems Jul 21, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

Aaron-Junker and others added 5 commits July 21, 2024 11:55

Fix spelling

23bcf78

Merge branch 'main' into dev/aaron-junker/FileActionsMenu

bd89670

Merge remote-tracking branch 'origin/main' into dev/aaron-junker/File…

e973e73

…ActionsMenu

Merge remote-tracking branch 'origin/main' into dev/aaron-junker/File…

403f3f5

…ActionsMenu

Update notice.md

07eed1c

stefansjfw reviewed Aug 6, 2024

View reviewed changes

stefansjfw reviewed Aug 7, 2024

View reviewed changes

Aaron-Junker added 2 commits August 9, 2024 22:00

Change name of new folder

fc9c343

Merge branch 'dev/aaron-junker/FileActionsMenu' of https://github.com…

afdd7bd

…/microsoft/PowerToys into dev/aaron-junker/FileActionsMenu

Aaron-Junker added 4 commits September 14, 2024 22:08

Merge main

d5f8e4b

test

27bd0fd

Fix build/make dpi aware

e77911f

No longer block ui thread when opening PowerToy

394f86c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

File Actions menu #31220

File Actions menu #31220

Aaron-Junker commented Feb 1, 2024 •

edited

Loading

Aaron-Junker commented Feb 1, 2024

github-advanced-security bot left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Aaron-Junker commented Jul 21, 2024 •

edited

Loading

This comment has been minimized.

stefansjfw left a comment

stefansjfw Aug 6, 2024

stefansjfw Aug 6, 2024

stefansjfw Aug 6, 2024

stefansjfw Aug 6, 2024

Aaron-Junker Aug 9, 2024

stefansjfw Aug 6, 2024

stefansjfw Aug 6, 2024

stefansjfw Aug 6, 2024

stefansjfw Aug 6, 2024

stefansjfw Aug 6, 2024

stefansjfw Aug 6, 2024

Aaron-Junker Aug 9, 2024

stefansjfw commented Aug 6, 2024 •

edited

Loading

Aaron-Junker commented Aug 6, 2024

stefansjfw commented Aug 6, 2024 •

edited

Loading

stefansjfw commented Aug 6, 2024

stefansjfw commented Aug 7, 2024

azure-pipelines bot commented Aug 7, 2024

stefansjfw left a comment

stefansjfw Aug 7, 2024

stefansjfw Aug 7, 2024

stefansjfw commented Aug 7, 2024 •

edited

Loading

htcfreek commented Sep 12, 2024

		<PackageVersion Include="Microsoft.Toolkit.Uwp.Notifications" Version="7.1.2" />
		<PackageVersion Include="Microsoft.UI.Xaml" Version="2.8.6" />


		public IAction[]? SubMenuItems => null;

		public int Category => 2;


		public IconElement? Icon => new FontIcon { Glyph = "\ue74d" };

		public bool IsVisible => SelectedItems.Length == 1


		public string[] SelectedItems { get => _selectedItems.GetOrArgumentNullException(); set => _selectedItems = value; }

		public string Title => "As for XML encoded string";


		public IconElement? Icon => new FontIcon { Glyph = "\ue785" };

		public bool IsVisible => SelectedItems.Any(file => File.Exists(file + ":Zone.Identifier"));

File Actions menu #31220

Are you sure you want to change the base?

File Actions menu #31220

Conversation

Aaron-Junker commented Feb 1, 2024 • edited Loading

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Aaron-Junker commented Feb 1, 2024

github-advanced-security bot left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Aaron-Junker commented Jul 21, 2024 • edited Loading

This comment has been minimized.

stefansjfw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stefansjfw commented Aug 6, 2024 • edited Loading

Aaron-Junker commented Aug 6, 2024

stefansjfw commented Aug 6, 2024 • edited Loading

stefansjfw commented Aug 6, 2024

stefansjfw commented Aug 7, 2024

azure-pipelines bot commented Aug 7, 2024

stefansjfw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stefansjfw commented Aug 7, 2024 • edited Loading

htcfreek commented Sep 12, 2024

Aaron-Junker commented Feb 1, 2024 •

edited

Loading

Aaron-Junker commented Jul 21, 2024 •

edited

Loading

stefansjfw commented Aug 6, 2024 •

edited

Loading

stefansjfw commented Aug 6, 2024 •

edited

Loading

stefansjfw commented Aug 7, 2024 •

edited

Loading