Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CardTransformerProvider class #139

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

mac-gallagher
Copy link
Owner

  • Remove CardTransformerProvider class
  • Rename (internal) SwipeCardDelegate methods to be more consistent with UIScrollViewDelegate naming conventions
  • Add cardDidFinishSwipeAnimation delegate method in favor of using the Notification Center
  • Remove CardStackAnimatableOptions and CardAnimatableOptions protocols as they served no purpose

@codecov-io
Copy link

Codecov Report

Merging #139 (48bc7dc) into master (48b8f4a) will decrease coverage by 0.1%.
The diff coverage is 85.4%.

@@           Coverage Diff            @@
##           master    #139     +/-   ##
========================================
- Coverage    84.1%   83.9%   -0.2%     
========================================
  Files          11      10      -1     
  Lines         724     715      -9     
========================================
- Hits          609     600      -9     
  Misses        115     115             
Impacted Files Coverage Δ
...uffle/Classes/SwipeCard/CardAnimationOptions.swift 100.0% <ø> (ø)
...ses/SwipeCardStack/CardStackAnimationOptions.swift 100.0% <ø> (ø)
...fle/Classes/SwipeCardStack/CardStackAnimator.swift 0.0% <0.0%> (ø)
...Classes/SwipeCardStack/CardStackStateManager.swift 100.0% <ø> (ø)
Sources/Shuffle/Classes/SwipeCard/SwipeCard.swift 100.0% <100.0%> (ø)
...huffle/Classes/SwipeCardStack/SwipeCardStack.swift 100.0% <100.0%> (ø)

@mac-gallagher mac-gallagher merged commit 7f0edf5 into master Apr 7, 2021
@mac-gallagher mac-gallagher deleted the remove-transform-provider branch April 7, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants