Skip to content

Commit

Permalink
Remove transform providers classes
Browse files Browse the repository at this point in the history
  • Loading branch information
@mac-gallagher
mac-gallagher committed Apr 7, 2021
1 parent 48b8f4a commit 39e1331
Show file tree
Hide file tree
Showing 20 changed files with 269 additions and 488 deletions.
20 changes: 4 additions & 16 deletions Example/Shuffle.xcodeproj/project.pbxproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
/* Begin PBXBuildFile section */
13428DB08D67C399311FF2FC /* Pods_ShuffleExample.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 4664D842E2EB45B708F03949 /* Pods_ShuffleExample.framework */; };
81052FC54C519D4BC1A59A50 /* Pods_ShuffleTests.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 96E655EA6DB7A38C33ED8F64 /* Pods_ShuffleTests.framework */; };
AD8E593A261D939100E99C62 /* SwipeCardTest_Layout.swift in Sources */ = {isa = PBXBuildFile; fileRef = AD8E5939261D939100E99C62 /* SwipeCardTest_Layout.swift */; };
ADF646DA261A5CD200FE6BA3 /* TinderCardContentView.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF646CB261A5CD200FE6BA3 /* TinderCardContentView.swift */; };
ADF646DB261A5CD200FE6BA3 /* TinderCardModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF646CC261A5CD200FE6BA3 /* TinderCardModel.swift */; };
ADF646DC261A5CD200FE6BA3 /* TinderCardFooterView.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF646CD261A5CD200FE6BA3 /* TinderCardFooterView.swift */; };
Expand All @@ -34,19 +35,15 @@
ADF646E4261A5CD200FE6BA3 /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF646D8261A5CD200FE6BA3 /* AppDelegate.swift */; };
ADF646E5261A5CD200FE6BA3 /* Images.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = ADF646D9261A5CD200FE6BA3 /* Images.xcassets */; };
ADF646EF261A5D2700FE6BA3 /* LaunchScreen.xib in Resources */ = {isa = PBXBuildFile; fileRef = ADF646ED261A5D2700FE6BA3 /* LaunchScreen.xib */; };
ADF6476C261A62D000FE6BA3 /* TestableNotificationCenter.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF64744261A62D000FE6BA3 /* TestableNotificationCenter.swift */; };
ADF6476E261A62D000FE6BA3 /* MockCardAnimator.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF64748261A62D000FE6BA3 /* MockCardAnimator.swift */; };
ADF6476F261A62D000FE6BA3 /* MockSwipeCardDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF64749261A62D000FE6BA3 /* MockSwipeCardDelegate.swift */; };
ADF64771261A62D000FE6BA3 /* MockCardTransformProvider.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF6474B261A62D000FE6BA3 /* MockCardTransformProvider.swift */; };
ADF64772261A62D000FE6BA3 /* CardTransformProviderTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF6474D261A62D000FE6BA3 /* CardTransformProviderTest.swift */; };
ADF64774261A62D000FE6BA3 /* CardAnimatorTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF6474F261A62D000FE6BA3 /* CardAnimatorTest.swift */; };
ADF64775261A62D000FE6BA3 /* SwipeViewTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF64750261A62D000FE6BA3 /* SwipeViewTest.swift */; };
ADF64776261A62D000FE6BA3 /* CardAnimationOptionsTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF64751261A62D000FE6BA3 /* CardAnimationOptionsTest.swift */; };
ADF64777261A62D000FE6BA3 /* SwipeCardTest_Base.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF64752261A62D000FE6BA3 /* SwipeCardTest_Base.swift */; };
ADF64778261A62D000FE6BA3 /* SwipeCardTest_MainMethods.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF64753261A62D000FE6BA3 /* SwipeCardTest_MainMethods.swift */; };
ADF64779261A62D000FE6BA3 /* TestableSwipeCard.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF64755261A62D000FE6BA3 /* TestableSwipeCard.swift */; };
ADF6477A261A62D000FE6BA3 /* TestableSwipeView.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF64756261A62D000FE6BA3 /* TestableSwipeView.swift */; };
ADF6477B261A62D000FE6BA3 /* TestableCardTransformProvider.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF64757261A62D000FE6BA3 /* TestableCardTransformProvider.swift */; };
ADF6477C261A62D000FE6BA3 /* TestableCardAnimator.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF64758261A62D000FE6BA3 /* TestableCardAnimator.swift */; };
ADF6477E261A62D000FE6BA3 /* MockCardStackStateManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF6475C261A62D000FE6BA3 /* MockCardStackStateManager.swift */; };
ADF6477F261A62D000FE6BA3 /* MockSwipeCardStackDataSource.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADF6475D261A62D000FE6BA3 /* MockSwipeCardStackDataSource.swift */; };
Expand All @@ -72,6 +69,7 @@
6AD5D90D898A5D96840E619C /* README.md */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = net.daringfireball.markdown; name = README.md; path = ../README.md; sourceTree = "<group>"; };
6D7D80EFAC2C40B10D76131E /* Shuffle-iOS.podspec */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text; name = "Shuffle-iOS.podspec"; path = "../Shuffle-iOS.podspec"; sourceTree = "<group>"; xcLanguageSpecificationIdentifier = xcode.lang.ruby; };
96E655EA6DB7A38C33ED8F64 /* Pods_ShuffleTests.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_ShuffleTests.framework; sourceTree = BUILT_PRODUCTS_DIR; };
AD8E5939261D939100E99C62 /* SwipeCardTest_Layout.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SwipeCardTest_Layout.swift; sourceTree = "<group>"; };
ADF646CB261A5CD200FE6BA3 /* TinderCardContentView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = TinderCardContentView.swift; sourceTree = "<group>"; };
ADF646CC261A5CD200FE6BA3 /* TinderCardModel.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = TinderCardModel.swift; sourceTree = "<group>"; };
ADF646CD261A5CD200FE6BA3 /* TinderCardFooterView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = TinderCardFooterView.swift; sourceTree = "<group>"; };
Expand All @@ -84,20 +82,16 @@
ADF646D8261A5CD200FE6BA3 /* AppDelegate.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = AppDelegate.swift; sourceTree = "<group>"; };
ADF646D9261A5CD200FE6BA3 /* Images.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Images.xcassets; sourceTree = "<group>"; };
ADF646EE261A5D2700FE6BA3 /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.xib; name = Base; path = Base.lproj/LaunchScreen.xib; sourceTree = "<group>"; };
ADF64744261A62D000FE6BA3 /* TestableNotificationCenter.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = TestableNotificationCenter.swift; sourceTree = "<group>"; };
ADF64745261A62D000FE6BA3 /* ShuffleTests.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = ShuffleTests.plist; sourceTree = "<group>"; };
ADF64748261A62D000FE6BA3 /* MockCardAnimator.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = MockCardAnimator.swift; sourceTree = "<group>"; };
ADF64749261A62D000FE6BA3 /* MockSwipeCardDelegate.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = MockSwipeCardDelegate.swift; sourceTree = "<group>"; };
ADF6474B261A62D000FE6BA3 /* MockCardTransformProvider.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = MockCardTransformProvider.swift; sourceTree = "<group>"; };
ADF6474D261A62D000FE6BA3 /* CardTransformProviderTest.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CardTransformProviderTest.swift; sourceTree = "<group>"; };
ADF6474F261A62D000FE6BA3 /* CardAnimatorTest.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CardAnimatorTest.swift; sourceTree = "<group>"; };
ADF64750261A62D000FE6BA3 /* SwipeViewTest.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SwipeViewTest.swift; sourceTree = "<group>"; };
ADF64751261A62D000FE6BA3 /* CardAnimationOptionsTest.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CardAnimationOptionsTest.swift; sourceTree = "<group>"; };
ADF64752261A62D000FE6BA3 /* SwipeCardTest_Base.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SwipeCardTest_Base.swift; sourceTree = "<group>"; };
ADF64753261A62D000FE6BA3 /* SwipeCardTest_MainMethods.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SwipeCardTest_MainMethods.swift; sourceTree = "<group>"; };
ADF64755261A62D000FE6BA3 /* TestableSwipeCard.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = TestableSwipeCard.swift; sourceTree = "<group>"; };
ADF64756261A62D000FE6BA3 /* TestableSwipeView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = TestableSwipeView.swift; sourceTree = "<group>"; };
ADF64757261A62D000FE6BA3 /* TestableCardTransformProvider.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = TestableCardTransformProvider.swift; sourceTree = "<group>"; };
ADF64758261A62D000FE6BA3 /* TestableCardAnimator.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = TestableCardAnimator.swift; sourceTree = "<group>"; };
ADF6475C261A62D000FE6BA3 /* MockCardStackStateManager.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = MockCardStackStateManager.swift; sourceTree = "<group>"; };
ADF6475D261A62D000FE6BA3 /* MockSwipeCardStackDataSource.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = MockSwipeCardStackDataSource.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -246,8 +240,8 @@
children = (
ADF64751261A62D000FE6BA3 /* CardAnimationOptionsTest.swift */,
ADF6474F261A62D000FE6BA3 /* CardAnimatorTest.swift */,
ADF6474D261A62D000FE6BA3 /* CardTransformProviderTest.swift */,
ADF64752261A62D000FE6BA3 /* SwipeCardTest_Base.swift */,
AD8E5939261D939100E99C62 /* SwipeCardTest_Layout.swift */,
ADF64753261A62D000FE6BA3 /* SwipeCardTest_MainMethods.swift */,
ADF64750261A62D000FE6BA3 /* SwipeViewTest.swift */,
);
Expand All @@ -273,7 +267,6 @@
ADF64748261A62D000FE6BA3 /* MockCardAnimator.swift */,
ADF6475F261A62D000FE6BA3 /* MockCardStackAnimator.swift */,
ADF64760261A62D000FE6BA3 /* MockCardStackTransformProvider.swift */,
ADF6474B261A62D000FE6BA3 /* MockCardTransformProvider.swift */,
ADF6475C261A62D000FE6BA3 /* MockCardStackStateManager.swift */,
ADF64749261A62D000FE6BA3 /* MockSwipeCardDelegate.swift */,
ADF6475D261A62D000FE6BA3 /* MockSwipeCardStackDataSource.swift */,
Expand All @@ -287,8 +280,6 @@
children = (
ADF64758261A62D000FE6BA3 /* TestableCardAnimator.swift */,
ADF6476B261A62D000FE6BA3 /* TestableCardStackStateManager.swift */,
ADF64757261A62D000FE6BA3 /* TestableCardTransformProvider.swift */,
ADF64744261A62D000FE6BA3 /* TestableNotificationCenter.swift */,
ADF64755261A62D000FE6BA3 /* TestableSwipeCard.swift */,
ADF6476A261A62D000FE6BA3 /* TestableSwipeCardStack.swift */,
ADF64756261A62D000FE6BA3 /* TestableSwipeView.swift */,
Expand Down Expand Up @@ -589,7 +580,7 @@
buildActionMask = 2147483647;
files = (
ADF64789261A62D000FE6BA3 /* SwipeCardStackTest_Base.swift in Sources */,
ADF64772261A62D000FE6BA3 /* CardTransformProviderTest.swift in Sources */,
AD8E593A261D939100E99C62 /* SwipeCardTest_Layout.swift in Sources */,
ADF64777261A62D000FE6BA3 /* SwipeCardTest_Base.swift in Sources */,
ADF6477E261A62D000FE6BA3 /* MockCardStackStateManager.swift in Sources */,
ADF64775261A62D000FE6BA3 /* SwipeViewTest.swift in Sources */,
Expand All @@ -603,8 +594,6 @@
ADF6476E261A62D000FE6BA3 /* MockCardAnimator.swift in Sources */,
ADF64782261A62D000FE6BA3 /* MockCardStackTransformProvider.swift in Sources */,
ADF64780261A62D000FE6BA3 /* MockSwipeCardStackDelegate.swift in Sources */,
ADF64771261A62D000FE6BA3 /* MockCardTransformProvider.swift in Sources */,
ADF6476C261A62D000FE6BA3 /* TestableNotificationCenter.swift in Sources */,
ADF64784261A62D000FE6BA3 /* CardStackStateManagerTest.swift in Sources */,
ADF6478B261A62D000FE6BA3 /* TestableCardStackStateManager.swift in Sources */,
ADF64779261A62D000FE6BA3 /* TestableSwipeCard.swift in Sources */,
Expand All @@ -613,7 +602,6 @@
ADF64786261A62D000FE6BA3 /* SwipeCardStackTest_SwipeCardDelegate.swift in Sources */,
ADF64783261A62D000FE6BA3 /* SwipeCardStackTest_MainMethods.swift in Sources */,
ADF6477C261A62D000FE6BA3 /* TestableCardAnimator.swift in Sources */,
ADF6477B261A62D000FE6BA3 /* TestableCardTransformProvider.swift in Sources */,
ADF6478A261A62D000FE6BA3 /* TestableSwipeCardStack.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
Expand Down
49 changes: 0 additions & 49 deletions Example/Tests/Mocks/MockCardTransformProvider.swift
View file

This file was deleted.

15 changes: 10 additions & 5 deletions Example/Tests/Mocks/MockSwipeCardDelegate.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,30 +28,35 @@ import UIKit
class MockSwipeCardDelegate: SwipeCardDelegate {

var didBeginSwipeCalled: Bool = false
func card(didBeginSwipe card: SwipeCard) {
func cardDidBeginSwipe(_ card: SwipeCard) {
didBeginSwipeCalled = true
}

var didCancelSwipeCalled: Bool = false
func card(didCancelSwipe card: SwipeCard) {
func cardDidCancelSwipe(_ card: SwipeCard) {
didCancelSwipeCalled = true
}

var didContinueSwipeCalled: Bool = false
func card(didContinueSwipe card: SwipeCard) {
func cardDidContinueSwipe(_ card: SwipeCard) {
didContinueSwipeCalled = true
}

var cardDidFinishSwipeAnimationCalled: Bool = false
func cardDidFinishSwipeAnimation(_ card: SwipeCard) {
cardDidFinishSwipeAnimationCalled = true
}

var didSwipeCalled: Bool = false
var didSwipeDirection: SwipeDirection?

func card(didSwipe card: SwipeCard, with direction: SwipeDirection) {
func cardDidSwipe(_ card: SwipeCard, withDirection direction: SwipeDirection) {
didSwipeCalled = true
didSwipeDirection = direction
}

var didTapCalled: Bool = false
func card(didTap card: SwipeCard) {
func cardDidTap(_ card: SwipeCard) {
didTapCalled = true
}

Expand Down
37 changes: 2 additions & 35 deletions Example/Tests/SwipeCardStackTests/SwipeCardStackTest_MainMethods.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import Quick
@testable import Shuffle_iOS
import UIKit

// swiftlint:disable type_body_length closure_body_length implicitly_unwrapped_optional
// swiftlint:disable closure_body_length implicitly_unwrapped_optional
class SwipeCardStackTest_MainMethods: QuickSpec {

typealias Card = SwipeCardStack.Card
Expand Down Expand Up @@ -539,39 +539,6 @@ class SwipeCardStackTest_MainMethods: QuickSpec {
}
}
}

// MARK: - Did Finish Swipe Animation

describe("When calling didFinishSwipeAnimation") {
context("and the notification object is not a SwipeCard") {
beforeEach {
let notification = NSNotification(name: CardDidFinishSwipeAnimationNotification,
object: UIView())
subject.didFinishSwipeAnimation(notification)
}

it("should do nothing!") {
//do nothing
}
}

context("and the notification object is a SwipeCard") {
let swipeCard = SwipeCard()

beforeEach {
let superview = UIView()
superview.addSubview(swipeCard)

let notification = NSNotification(name: CardDidFinishSwipeAnimationNotification,
object: swipeCard)
subject.didFinishSwipeAnimation(notification)
}

it("should remove the card from its superview") {
expect(swipeCard.superview).to(beNil())
}
}
}
}
}
// swiftlint:enable type_body_length closure_body_length implicitly_unwrapped_optional
// swiftlint:enable closure_body_length implicitly_unwrapped_optional
Loading

0 comments on commit 39e1331

Please sign in to comment.