Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Google CDN for k8s-artifacts-prod bucket #3328

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Enable Google CDN for k8s-artifacts-prod bucket #3328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Enable Google CDN for k8s-artifacts-prod bucket 
Related:
  - #3327

Signed-off-by: Arnaud Meukam <[email protected]>
  • Loading branch information
@ameukam
ameukam committed Feb 1, 2022
commit fee3f3fd10676e80940360c05fae2f9020f72c35
2 changes: 1 addition & 1 deletion infra/gcp/bash/ensure-prod-storage-gclb.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ color 6 "Reconciling GCLB Backend Bucket"
if ! gcloud --project "${PROD_PROJECT}" compute backend-buckets describe "${NAME}" >/dev/null 2>&1; then
gcloud --project "${PROD_PROJECT}" compute backend-buckets create "${NAME}" --gcs-bucket-name="${BUCKET_NAME}"
else
gcloud --project "${PROD_PROJECT}" compute backend-buckets update "${NAME}" --gcs-bucket-name="${BUCKET_NAME}"
gcloud --project "${PROD_PROJECT}" compute backend-buckets update "${NAME}" --gcs-bucket-name="${BUCKET_NAME}" --enable-cdn --cache-mode=FORCE_CACHE_ALL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FORCE_CACHE_ALL defaults to a TTL of 1 hour (https://cloud.google.com/cdn/docs/caching), which is probably a fine starting point.

/lgtm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@endocrimes targeting a TTL of 30 days for this. https://cloud.google.com/cdn/docs/using-ttl-overrides

fi

color 6 "Reconciling GCLB URL Map"
Expand Down