Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Google CDN for k8s-artifacts-prod bucket #3328

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Enable Google CDN for k8s-artifacts-prod bucket #3328

merged 1 commit into from
Feb 1, 2022

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Feb 1, 2022

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ labels Feb 1, 2022
@k8s-ci-robot k8s-ci-robot added area/infra Infrastructure management, infrastructure design, code in infra/ approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Feb 1, 2022
@ameukam
Copy link
Member Author

ameukam commented Feb 1, 2022

cc @justinsb @johngmyers
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2022
@dims
Copy link
Member

dims commented Feb 1, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2022
endocrimes
endocrimes approved these changes Feb 1, 2022
View reviewed changes
infra/gcp/bash/ensure-prod-storage-gclb.sh
@@ -62,7 +62,7 @@ color 6 "Reconciling GCLB Backend Bucket"
if ! gcloud --project "${PROD_PROJECT}" compute backend-buckets describe "${NAME}" >/dev/null 2>&1; then
gcloud --project "${PROD_PROJECT}" compute backend-buckets create "${NAME}" --gcs-bucket-name="${BUCKET_NAME}"
else
gcloud --project "${PROD_PROJECT}" compute backend-buckets update "${NAME}" --gcs-bucket-name="${BUCKET_NAME}"
gcloud --project "${PROD_PROJECT}" compute backend-buckets update "${NAME}" --gcs-bucket-name="${BUCKET_NAME}" --enable-cdn --cache-mode=FORCE_CACHE_ALL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FORCE_CACHE_ALL defaults to a TTL of 1 hour (https://cloud.google.com/cdn/docs/caching), which is probably a fine starting point.

/lgtm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@endocrimes targeting a TTL of 30 days for this. https://cloud.google.com/cdn/docs/using-ttl-overrides

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, dims, endocrimes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
Copy link
Member Author

ameukam commented Feb 1, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit e2e8b6f into kubernetes:main Feb 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 1, 2022
@ameukam
Copy link
Member Author

ameukam commented Feb 1, 2022

Deployment done:

❯ ./ensure-prod-storage-gclb.sh
Ensuring project exists: k8s-artifacts-prod 
Enabling the compute API: k8s-artifacts-prod 
Reconciling Global Address 
Address: 35.244.192.77
Reconciling GCLB Backend Bucket 
Updated [https://www.googleapis.com/compute/v1/projects/k8s-artifacts-prod/global/backendBuckets/k8s-artifacts-prod].
Reconciling GCLB URL Map 
Updated [https://www.googleapis.com/compute/v1/projects/k8s-artifacts-prod/global/urlMaps/k8s-artifacts-prod].
Reconciling GCLB Target HTTP Proxy 
Updated [https://www.googleapis.com/compute/v1/projects/k8s-artifacts-prod/global/targetHttpProxies/k8s-artifacts-prod].
Reconciling GCLB Forwarding Rule for HTTP 
Updated [https://www.googleapis.com/compute/v1/projects/k8s-artifacts-prod/global/forwardingRules/k8s-artifacts-prod-http].
Reconciling GCLB SSL Certificate 
Reconciling GCLB Target HTTPS Proxy 
Updated [https://www.googleapis.com/compute/v1/projects/k8s-artifacts-prod/global/targetHttpsProxies/k8s-artifacts-prod].
Updated [https://www.googleapis.com/compute/v1/projects/k8s-artifacts-prod/global/targetHttpsProxies/k8s-artifacts-prod].
Reconciling GCLB Forwarding Rule for HTTPS 
Updated [https://www.googleapis.com/compute/v1/projects/k8s-artifacts-prod/global/forwardingRules/k8s-artifacts-prod-https].
Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

@spiffxp spiffxp Awaiting requested review from spiffxp

@thockin thockin Awaiting requested review from thockin

Assignees

@dims dims

@endocrimes endocrimes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@ameukam @dims @k8s-ci-robot @endocrimes