Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify rendering logic for grids with merged cells #197

Merged
merged 9 commits into from
Jul 16, 2021
Merged

Simplify rendering logic for grids with merged cells #197

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7de6f56
Fix wrong width edge case for column headers
ibdafna Jun 22, 2021
a24b6eb
Use correct column size
ibdafna Jun 22, 2021
7e67047
Greatly simplify rendering logic for grid with merged cells
ibdafna Jul 3, 2021
3caae17
Fix typo
ibdafna Jul 16, 2021
706c1b6
Fix rendering issue with blit logic
ibdafna Jul 16, 2021
23e2811
Restore _scrollTo() docstring
ibdafna Jul 16, 2021
55270f5
Add check for data model in _scrollTo
ibdafna Jul 16, 2021
46a495c
Refactor: 'paintEverything' as a private method
ibdafna Jul 16, 2021
f99f5da
Refactor 'extendLines' to use same check as 'paintEverything'
ibdafna Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo 
Signed-off-by: Itay Dafna <[email protected]>
  • Loading branch information
@ibdafna
ibdafna committed Jul 16, 2021
commit 3caae17288325b1ec9a3d3a7aa9485a9ce0bbace
2 changes: 1 addition & 1 deletion packages/datagrid/src/cellgroup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ export namespace CellGroup {
* same region if they intersect.
* @param dataModel the data model of the grid.
* @param group the target cell group.
* @param region the region wer're of the cell group.
* @param region the region of the cell group.
* @returns a new cell group after merging has happened.
*/
export function joinCellGroupWithMergedCellGroups(
Expand Down