Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify rendering logic for grids with merged cells #197

Merged
merged 9 commits into from
Jul 16, 2021
Merged

Simplify rendering logic for grids with merged cells #197

merged 9 commits into from
Jul 16, 2021

Commits on Jun 22, 2021

  1. Fix wrong width edge case for column headers 

    Signed-off-by: Itay Dafna <[email protected]>
    @ibdafna
    ibdafna committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    7de6f56 View commit details
    Browse the repository at this point in the history

  2. Use correct column size 

    Signed-off-by: Itay Dafna <[email protected]>
    @ibdafna
    ibdafna committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    a24b6eb View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2021

  1. Greatly simplify rendering logic for grid with merged cells 

    Signed-off-by: Itay Dafna <[email protected]>
    @ibdafna
    ibdafna committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    7e67047 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. Fix typo 

    Signed-off-by: Itay Dafna <[email protected]>
    @ibdafna
    ibdafna committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    3caae17 View commit details
    Browse the repository at this point in the history

  2. Fix rendering issue with blit logic 

    Signed-off-by: Itay Dafna <[email protected]>
    @ibdafna
    ibdafna committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    706c1b6 View commit details
    Browse the repository at this point in the history

  3. Restore _scrollTo() docstring 

    Signed-off-by: Itay Dafna <[email protected]>
    @ibdafna
    ibdafna committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    23e2811 View commit details
    Browse the repository at this point in the history

  4. Add check for data model in _scrollTo 

    Signed-off-by: Itay Dafna <[email protected]>
    @ibdafna
    ibdafna committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    55270f5 View commit details
    Browse the repository at this point in the history

  5. Refactor: 'paintEverything' as a private method 

    Signed-off-by: Itay Dafna <[email protected]>
    @ibdafna
    ibdafna committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    46a495c View commit details
    Browse the repository at this point in the history

  6. Refactor 'extendLines' to use same check as 'paintEverything' 

    Signed-off-by: Itay Dafna <[email protected]>
    @ibdafna
    ibdafna committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    f99f5da View commit details
    Browse the repository at this point in the history