Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling on g g and G #137

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

krassowski
Copy link
Collaborator

@krassowski krassowski commented Feb 7, 2024

Closes #134

To add more context, we should make this change anyways, because otherwise scrolling would not work in the full windowing mode.

@krassowski krassowski added the bug Something isn't working label Feb 7, 2024
Copy link

github-actions bot commented Feb 7, 2024

Binder 👈 Launch a Binder on branch krassowski/jupyterlab-vim/scrolling-fix-for-lab-4.1

Copy link

@lukashergt lukashergt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried out the binder. gg and G working as expected, jumping to top/bottom cell respectively and the view jumps, too, i.e. the scrolling seems to be working now. Thanks for the speedy fix @krassowski!

@ianhi
Copy link
Collaborator

ianhi commented Feb 8, 2024

This does indeed fix the scrolling but I think it's doing something weird to selection state of the cell. When i do this I have to hit enter twice in order to get to cell edit (vim normal) mode. In contrast when in jupyter command mode if I move up a cell with j then it only takes one enter press to accomplish the same.

Copy link
Collaborator

@ianhi ianhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to figure out the best way to get us into jupyter-command-mode with the scrolled to cell one enter press away from being in edit mode. I have one suggestion i added to the review but im not sure it's the best way. I wish there was an option in scrollToCell that allowed you choose whether to enter edit mode.

src/labCommands.ts Outdated Show resolved Hide resolved
@krassowski krassowski requested a review from ianhi February 8, 2024 08:47
Copy link
Collaborator

@ianhi ianhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick follow up fixes @krassowski !

@ianhi ianhi merged commit 7aa48c1 into jupyterlab-contrib:main Feb 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gg and G no longer working in jupyterlab 4.1.0
3 participants