gg and G no longer working in jupyterlab 4.1.0

[lukashergt]

Description

After updating from jupyterlab 4.0.11 to jupyterlab 4.1.0, the commands gg and G to navigate to the top/bottom cell of the notebook in jupyter mode no longer seem to work. Going back to jupyterlab 4.0.11 both gg and G work as expected.

Can anybody else confirm this?

Context

• Python version: 3.12.1
• jupyterlab-vim version: 4.1.0
• Operating System and its version: Linux Manjaro
• Browser and its version: Firefox 122.0-1

[ianhi]

edit: I was able to replicate i misread the issue at first

---

I was not able to replicate on:

python : 3.12.1
jupyterlab-vim: 4.1.0
jupyterlab : 4.1.0
firefox: 112 (on linux)

Was this in a totally fresh environment?

[lukashergt]

I was not able to replicate on:

python : 3.12.1
jupyterlab-vim: 4.1.0
jupyterlab : 4.1.0
firefox: 112 (on linux)

Huh, weird.

Was this in a totally fresh environment?

Yes, new virtualenv...

[lukashergt]

I tried again with a fresh virtualenv of python version 3.11.5. Same thing, gg and G work in jupyterlab==4.0.11, but do not work in jupyterlab==4.1.0...

[petergthatsme]

I can confirm, and for me other shortcuts stopped working in 4.1.0 as well e.g,. shift+O.
I downgraded to 4.0.11 for now, and things are ok.
thx.

[ianhi]

ahhh sorry i misread the original issue, i thought you were talking about inside of a cell. I agree I see the same

[ianhi]

ahhh I suspect we need to update the CSS selectors: https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#change-of-notebook-focus-handling-impacting-command-mode-shortcut-selectors

[krassowski]

Yes, but JupyterLab 4.1 was supposed to handle the transition by transparent substitution in the background. I must have missed some selectors, sorry 🤦

[krassowski]

So jupyterlab/jupyterlab#15639 should have caught .jp-Notebook:focus usage as in:

jupyterlab-vim/schema/plugin.json

Lines 173 to 177 in fc42ef6

	{
	"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
	"keys": ["G", "G"],
	"command": "vim:select-first-cell"
	},

[krassowski]

Ok, the selector substitution rules are good but only first shortcut gets fixed (for me Y Y):

instead there is a bug in the logic in:

if (
  oldSelector.includes(change.old) &&
  !selectorsAlreadyWarnedAbout.has(oldSelector)
) {
  newSelector = oldSelector.replace(change.old, change.new);
  selectorDeprecationWarnings.add(
    `"${change.old}" was replaced with "${change.new}" in ${change.versionDeprecated} (present in "${oldSelector}")`
  );
  selectorsAlreadyWarnedAbout.add(oldSelector);
}

selectorsAlreadyWarnedAbout should not be checked in the outer if as it skips subsequent shortcuts. I will open a PR against JupyterLab,

[krassowski]

This is getting fixed in:

• Fix migration of command selectors for shortcuts jupyterlab/jupyterlab#15762 and
• Migrate shortcut selectors for JupyterLab 4.1+ #135

reviews for both pull requests would be greatly appreciated!

[lukashergt]

I can confirm that with #135 gg and G now jump to the top and bottom cell of the notebook, respectively.

However, it seems the view does not jump. For example, if I am at the bottom of the notebook viewing the bottom cell which is currently highlighted, and I then press gg, then the highlight vanishes (and presumably jumps to the top cell), but I am still looking at the bottom cell. Only after pressing j or k or zz (at least twice actually...) does the view follow and jump to the selected cell...

[krassowski]

Thank you @ianhi for the quick release and @lukashergt for testing. The scroller node has also changed in lab 4.1 (https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#css-class-name-change-in-the-windowedlist-superclass-of-staticnotebook), and instead of using the public API of notebook, this extension was doing scrolling manually:

jupyterlab-vim/src/labCommands.ts

Lines 248 to 253 in a6520ef

	if (content.activeCell !== null) {
	ElementExt.scrollIntoViewIfNeeded(
	content.node,
	content.activeCell.node
	);
	}

I can take a look tomorrow.

[ianhi]

ahhh sorry I didn't catch this. I did not make enough cells in my test notebook to trigger scrolling. I will add that to my mental checklist of things to check.

[lukashergt]

Wow, completely resolved as far as I can tell, thanks for these quick fixes @krassowski, @ianhi!