Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s9y-db importer permalink, tag, excerpt, and semantic HTML improvements #392

Merged
merged 20 commits into from
Apr 24, 2021
Merged

s9y-db importer permalink, tag, excerpt, and semantic HTML improvements #392

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
04bba1a
Safely duplicate S9Y excerpt / extended body formatting, if enabled
Sep 16, 2017
4741cb3
Support permalinks from S9Y entryproperties plugin
Sep 16, 2017
c256c35
Specify post type 'post' for entries
Sep 17, 2017
ace174a
Use correct option for tags
Sep 18, 2017
d1a4a0a
Process entryincludes plugin macros
Sep 24, 2017
43b46dd
Convert image-comment divs to figures
Dec 2, 2017
8bd7b3f
Replace absolute links with relative
Dec 2, 2017
98d158b
Convert tags to lower case
Dec 3, 2017
1ca3f14
Document new s9y-database importer options
Dec 23, 2018
e3a57cb
Merge cleanup
Dec 23, 2018
9543006
Fix iframe translation
Dec 28, 2018
08160bd
Rubocop cleanup
Jan 6, 2019
2acd4fc
Address PR comments
Jan 6, 2019
f299a3a
Rubocop compliance
Jan 6, 2019
00b56d4
Merge branch 'master' into s9y-db-judebert
ashmaroli Jan 6, 2019
cfa4354
Avoid duplicate checks of clean_entities and reverse_markdown options
Jan 7, 2019
fa2af27
chore(deps): add bundler
DirtyF Jan 6, 2019
dce9cd3
chore(ci): Add Ruby 2.6, drop Ruby 2.3
DirtyF Jan 6, 2019
75bd352
Update s9y-database importer docs for format and typos.
Jan 19, 2019
5058510
Merge branch 'master' into s9y-db-judebert
ashmaroli Jan 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix iframe translation
  • Loading branch information
Jude Anthony committed Jan 3, 2019
commit 9543006302f06d6d5a1dc4fd891acb65afe2d3d8
16 changes: 8 additions & 8 deletions lib/jekyll-import/importers/s9y_database.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ def self.process_img_div(text)
caption = "<figcaption>#{captionElem.inner_html}</figcaption>" if captionElem

imageNode = imgcaption.at_css('img')
youtubeNode = imgcaption.at_css('iframe')
iframeNode = imgcaption.at_css('iframe')
if imageNode
# Extract image attributes
width = imageNode.attribute('width')
Expand All @@ -393,14 +393,14 @@ def self.process_img_div(text)
img = "<a href='#{big}'>#{img}</a>"
end
# Create figure source with caption, if any
inc = "<figure class='figure_#{float}'#{style}>#{mdb}#{img}#{caption}</figure>"
elsif youtubeNode
inc = "<figure class='figure-#{float}'#{style}>#{mdb}#{img}#{caption}</figure>"
elsif iframeNode
# Extract iframe attributes
width = youtubeNode.attribute('width')
height = youtubeNode.attribute('height')
src = youtubeNode.attribute('src').value.sub('http://www.youtube.com/embed/', '').strip
width = iframeNode.attribute('width')
height = iframeNode.attribute('height')
src = iframeNode.attribute('src').value.strip
# Create clean iframe source
img = "<iframe src='#{src}' width='#{width}' height=#{height} alt=#{alt}/>"
img = "<iframe src='#{src}' width='#{width}' height=#{height}></iframe>"
# Wrap in link, if any
if bigLink
big = bigLink.attribute('href')
Expand All @@ -410,7 +410,7 @@ def self.process_img_div(text)
end
# Build figure source
inc = <<~EOT
<figure class='figure_#{float}' style='#{style}'>
<figure class='figure-#{float}' style='#{style}'>
<!-- mdb='#{mdbnum}' -->
#{fig}#{caption}
</figure>
Expand Down