s9y-db importer permalink, tag, excerpt, and semantic HTML improvements #392
Conversation
Document new s9y-database importer options
|
All PR comments addressed. script/cibuild passes on my computer. |
This comment has been minimized.
This comment has been minimized.
We use default gem tasks in our Rakefile
|
Friendly ping: I think I pushed another update addressing all issues, about 3 weeks ago. Is there anything else I need to do to merge? |
Apologies, @judebert. |
| c.option "drafts", "--drafts", "Whether to export drafts as well" | ||
| c.option "markdown", "--markdown", "convert into markdown format (default: false)" | ||
| c.option "permalinks", "--permalinks", "preserve S9Y permalinks (default: false)" | ||
| c.option "excerpt_separator", "--excerpt_separator", "Demarkation for excerpts (default: '<a id=\"extended\"></a>')" |
There was a problem hiding this comment.
- I personally feel
--excerpt_separatoris a bit long for a CLI flag. Could it be something shorter? If not, it is fine. - You've listed
<a id="extended"></a>as the default value for this flag. Should users provide a HTML string to override the default? "--excerpt_separator"is bare here. If it can receive an argument, it should be indicated in UPPERCASE. If not, this flag is considered as a Boolean type that toggles betweentrueorfalse- Typo: Demarcation is spelt (or spelled) with a
cnotk
| c.option "includeentry", "--includeentry", "Replace macros from the includeentry plugin (default: false)" | ||
| c.option "imgfig", "--imgfig", "Replace nested img and youtube divs with HTML figure tags (default: true)" | ||
| c.option "linebreak", "--linebreak", "Line break processing: wp, nokogiri, ignore (default: wp)" | ||
| c.option "relative", "--relative", "Convert links with this prefix to relative (default:nil)" |
There was a problem hiding this comment.
--linebreak takes an argument and hence needs a parameter alongside it: e.g.
--linebreak ARG and if --relative doesn't take an argument, the default should be false.
| # :imgfig:: Replace S9Y image-comment divs with an HTML figure | ||
| # div and figcaption, if applicable. Works for img and | ||
| # iframe. | ||
| # Default: true. | ||
| # |
There was a problem hiding this comment.
This separation is not present around other comments. Please remove.
|
|
||
| # Wrap media in link, if any | ||
| if big_link | ||
| big = big_link.attribute("href") |
There was a problem hiding this comment.
If big is not being used anywhere else, I think it could be avoided entirely:
media = "<a href='#{big_link.attribute("href")}'>#{media}</a>"
|
@jekyllbot: merge +minor |
These commits support plugins and properties required to migrate judebert.com from S9Y to Jekyll. The features include:
entrypropertiespluginDocumentation has been updated to describe the new functionality.