-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
per effect smoothing #456
per effect smoothing #456
Conversation
fix missing changes in prio muxer
- refactoring: std::min/max to qMin/Max
Perfect ! Great work |
Very cool!
So this option won't be shown until smoothing-custom-setting is true |
cool I always wanted such option :-) it's integrated now |
testbuild complete. from my side ready to merge. We can add custom smoothing settings to other effects later on ... |
- optimize random,candle and fadecandy json schemas
I have a question, is there a real diff between "enabled" and "pause" during usage? If you disable it, it is on kind of pause anway? |
pause is internal for effects and enable is for the user. We can rename 'pause' in 'enabled' in effects json ... this would look a bit nicer for users. |
So it does simply the "same". I think a merge is useful to reduce size! |
1. Tell us something about your changes.
this pr adds ability to set per effect smooting settings.
Smoothing settings are written in effect json file.
As default all effects without smoothing params in json config have smoothing disabled.
Currently I added smoothing settings only to effect "candle" and "random".
(others should follow, but I don't feel in a artistic mood today. Feel free to post settings for a specific effect as comment to this pr.)
new candle.json
Additionaly:
2. If this changes affect the .conf file. Please provide the changed section
3. Reference an issue (optional)
#447