Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effects smoothing+ #447

Closed
brindosch opened this issue Jun 26, 2017 · 4 comments
Closed

Effects smoothing+ #447

brindosch opened this issue Jun 26, 2017 · 4 comments
Labels

Comments

@brindosch
Copy link
Contributor

I want to bring back a point which isn't properly solved. Effects and smoothing. I see the follwing issues:

  • Some effects require it (candle, mood blobs) and others should use it too, instead running on device latchtime border. Well, it is smooth, but the cpu usage of hyperiond is on a Pi2 at around 40%, for the swirl which is very high.
  • Using the global smoothing for control about this is weird. The values might be too high and what happens if you run 2 effects which wants to enable and disable it? Check against the active one again?

From a code view it might be better to implement a own smoothing for the effect engine which could be build more dynamically for better control from effects.

#352
@penfold42

@penfold42
Copy link
Contributor

Personally I'd rather add smoothing settings to the effect schema and enhance the existing smoothing to be dynamic rather than just off/on

@redPanther
Copy link
Contributor

I have a nice idea. I'm on it ... stay tuned

@redPanther
Copy link
Contributor

issue solved?

@brindosch
Copy link
Contributor Author

I think so. Thank you
Will later on tune everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants