Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fetch overdue payments in dunning #42627

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: fetch overdue payments in dunning #42627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions erpnext/accounts/doctype/sales_invoice/sales_invoice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2653,6 +2653,7 @@ def postprocess_dunning(source, target):
target.language = letter_text.get("language")

# update outstanding
source.payment_schedule = []
if source.payment_schedule and len(source.payment_schedule) == 1:
target.overdue_payments[0].outstanding = source.get("outstanding_amount")
Comment on lines 2655 to 2658
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# update outstanding
source.payment_schedule = []
if source.payment_schedule and len(source.payment_schedule) == 1:
target.overdue_payments[0].outstanding = source.get("outstanding_amount")
# In the Sales Invoice, the outstanding amount of payment schedule might
# not be updated. This will be the case if it doesn't use a **Payment
# Terms Template** with _Allocate Payment Based On Payment Terms_
# enabled. In this case, we use the total outstanding amount from the
# Sales Invoice.
if source.payment_schedule and len(source.payment_schedule) == 1:
for row in target.overdue_payments:
if row.payment_schedule == source.payment_schedule[0].name:
row.outstanding = source.outstanding_amount


Expand Down
Loading