fix: fetch overdue payments in dunning

[Nihantra-Patel]

version 15

fixes: #42605

Before:

before_dunning.mp4

After:

after_dunning.mp4

[tonspar]

Perfect, thank you @Nihantra-Patel .

[daanlenaerts]

Hi @Nihantra-Patel, I found this issue because I was having the same problem with generating dunnings. Your changes do fix the problem, but I'm not sure there are no unintended side effects. Why do you add source.payment_schedule = [] instead of removing the next 2 lines? Which would have the same effect. I assume there's some reason these lines exist?

# update outstanding
source.payment_schedule = []
if source.payment_schedule and len(source.payment_schedule) == 1:
	target.overdue_payments[0].outstanding = source.get("outstanding_amount")

[Nihantra-Patel]

Lines you had were clearing out source.payment_schedule and handling only the case when there was just one payment schedule. This caused issues because you were losing data. Removing those lines helps to keep all the payment schedules and process them correctly.

So, instead of clearing source.payment_schedule and only checking for one payment schedule, just make sure you add all overdue payments to the target and keep everything as it is. This way, you don't miss any data and everything works as expected.

[daanlenaerts]

Thank you for your quick reply @Nihantra-Patel. That makes sense! And why did you keep the if statement? The condition is always false, as len(source.payment_schedule) is now always 0 due to the line you added?

[Nihantra-Patel]

Since source.payment_schedule is emptied before the check, the if statement will never be true. So, you don't need that if statement at all. Just keep the code that clears old payments and adds new ones to the target. This makes the code simpler and avoids any confusion. please check the video that i provided above.

[daanlenaerts]

Just keep the code that clears old payments and adds new ones to the target. This makes the code simpler and avoids any confusion.

Absolutely, that's my point :D The if statement is still present in your code, so it might be good to remove those lines to keep things clean. I would do it, but can't really because it's your bug fix.

[Nihantra-Patel]

Hmm 🤔

You said that if you remove/comment out the code below the outstanding will be updated? Did you test it?

I don't think it will be an outstanding update.

if source.payment_schedule and len(source.payment_schedule) == 1:
	target.overdue_payments[0].outstanding = source.get("outstanding_amount")

[daanlenaerts]

I'm not really saying that, all I'm saying is that the line you added in this fix ensures the if statement never succeeds, effectively rendering it useless. In which case it might be better to remove it.

However, to answer your question, I just tried actually removing the if statement and that does work (as it is effectively the same as your changes, it just makes the code cleaner). The outstanding amount is taken directly from the sales invoice's payment_schedule.

I do think that this would be an issue when a sales invoice would have multiple payment schedule lines, but I'm not sure when that's the case.

[barredterra]

Suggested change

	# update outstanding
	source.payment_schedule = []
	if source.payment_schedule and len(source.payment_schedule) == 1:
	target.overdue_payments[0].outstanding = source.get("outstanding_amount")
	# In the Sales Invoice, the outstanding amount of payment schedule might
	# not be updated. This will be the case if it doesn't use a **Payment
	# Terms Template** with _Allocate Payment Based On Payment Terms_
	# enabled. In this case, we use the total outstanding amount from the
	# Sales Invoice.
	if source.payment_schedule and len(source.payment_schedule) == 1:
	for row in target.overdue_payments:
	if row.payment_schedule == source.payment_schedule[0].name:
	row.outstanding = source.outstanding_amount