feat(fmgc): minimums exposed by fmgc

.github/CHANGELOG.md

@@ -76,6 +76,7 @@
 1. [MCDU] Implemented NAVAID page - @tracernz (Mike)
 1. [MCDU/ND] Implemented SPECIF VOR/D UNAVAIL message - @tracernz (Mike)
 1. [MCDU] Implemented TUNE BBB FFF.FF, SPECIF NDB UNAVAIL messages - @tracernz (Mike)
+1. [FMGC/PFD] Implemented FMGC exposure of the Minimums to the PFD - @MikioDK (Yekouri#1836)
 
 ## 0.9.0
 

fbw-a32nx/docs/a320-simvars.md

@@ -21,7 +21,7 @@
   - [Landing Gear (ATA 32)](#landing-gear-ata-32)
   - [ATC (ATA 34)](#atc-ata-34)
   - [Radio Altimeter (ATA 34)](#radio-altimeter-ata-34)
-  - [Electronic Flight Bag ATA 46](#electronic-flight-bag--ata-46-)
+  - [Electronic Flight Bag (ATA 46)](#electronic-flight-bag-ata-46)
 
 ## Uncategorized
 
@@ -1833,6 +1833,25 @@ In the variables below, {number} should be replaced with one item in the set: {
         - 1 - captain's side FMGC
         - 2 - f/o's side FMGC
 
+ - A32NX_FM{number}_DECISION_HEIGHT
+    - ARINC429<number>
+    - The decision height for an approach in feet, as entered on the PERF page.
+    - Value | Meaning
+       --- | ---
+       0 or greater | The decision height in feet
+       -1 | The pilot has not entered a decision height
+       -2 | The special value "NO" has been explicitly entered as the decision deight
+    - {number}
+        - 1 - captain's side FMGC
+        - 2 - f/o's side FMGC
+
+ - A32NX_FM{number}_MINIMUM_DESCENT_ALTITUDE
+    - ARINC429<number>
+    - The minimum descent altitude for a non-precision approach in feet, as entered on the PERF page.
+    - {number}
+        - 1 - captain's side FMGC
+        - 2 - f/o's side FMGC
+
 ## Autopilot System
 
 - A32NX_FMA_LATERAL_MODE

fbw-a32nx/src/base/flybywire-aircraft-a320-neo/html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/FMC/A32NX_FMCMainDisplay.js

@@ -177,6 +177,8 @@ class FMCMainDisplay extends BaseAirliners {
         this.arincLandingElevation = FmArinc429OutputWord.empty("LANDING_ELEVATION");
         this.arincDestinationLatitude = FmArinc429OutputWord.empty("DEST_LAT");
         this.arincDestinationLongitude = FmArinc429OutputWord.empty("DEST_LONG");
+        this.arincMDA = FmArinc429OutputWord.empty("MINIMUM_DESCENT_ALTITUDE");
+        this.arincDH = FmArinc429OutputWord.empty("DECISION_HEIGHT");
         this.arincThrustReductionAltitude = FmArinc429OutputWord.empty("THR_RED_ALT");
         this.arincAccelerationAltitude = FmArinc429OutputWord.empty("ACC_ALT");
         this.arincEoAccelerationAltitude = FmArinc429OutputWord.empty("EO_ACC_ALT");
@@ -192,6 +194,8 @@ class FMCMainDisplay extends BaseAirliners {
             this.arincLandingElevation,
             this.arincDestinationLatitude,
             this.arincDestinationLongitude,
+            this.arincMDA,
+            this.arincDH,
             this.arincThrustReductionAltitude,
             this.arincAccelerationAltitude,
             this.arincEoAccelerationAltitude,
@@ -200,7 +204,6 @@ class FMCMainDisplay extends BaseAirliners {
             this.arincMissedEoAccelerationAltitude,
         ];
     }
-
     Init() {
         super.Init();
         this.initVariables();
@@ -589,7 +592,7 @@ class FMCMainDisplay extends BaseAirliners {
             this.toSpeedsChecks();
             this.thrustReductionAccelerationChecks();
             this.updateThrustReductionAcceleration();
-
+            this.updateMinimums();
             this.updateIlsCourse();
         }
 
@@ -1597,6 +1600,20 @@ class FMCMainDisplay extends BaseAirliners {
         }
     }
 
+    updateMinimums() {
+        const inRange = this.shouldTransmitMinimums();
+        const MDAssm = inRange && this.perfApprMDA ? Arinc429Word.SignStatusMatrix.NormalOperation : Arinc429Word.SignStatusMatrix.NoComputedData;
+        const DHssm = inRange && this.perfApprDH ? Arinc429Word.SignStatusMatrix.NormalOperation : Arinc429Word.SignStatusMatrix.NoComputedData
+
+        this.arincMDA.setBnrValue(this.perfApprMDA ? this.perfApprMDA : 0, MDAssm, 17, 131072, 0);
+        this.arincDH.setBnrValue(this.perfApprDH ? this.perfApprDH : 0, DHssm, 16, 8192, 0);
+    }
+
+    shouldTransmitMinimums() {
+        const phase = this.flightPhaseManager.phase;
+        return (phase > FmgcFlightPhases.CRUISE || (phase === FmgcFlightPhases.CRUISE && this.flightPlanManager.getDistanceToDestination(FlightPlans.Active) < 250));
+    }
+
     getClbManagedSpeedFromCostIndex() {
         const dCI = (this.costIndex / 999) ** 2;
         return 290 * (1 - dCI) + 330 * dCI;

fbw-a32nx/src/systems/instruments/src/PFD/AltitudeIndicator.tsx

@@ -1,5 +1,5 @@
 import { ClockEvents, DisplayComponent, EventBus, FSComponent, Subject, Subscribable, VNode } from 'msfssdk';
-import { Arinc429SignStatusMatrix, Arinc429Word } from '@shared/arinc429';
+import { Arinc429Word } from '@shared/arinc429';
 import { VerticalMode } from '@shared/autopilot';
 import { PFDSimvars } from './shared/PFDSimvarPublisher';
 import { DigitalAltitudeReadout } from './DigitalAltitudeReadout';
@@ -180,10 +180,9 @@ class MinimumDescentAltitudeIndicator extends DisplayComponent<{ bus: EventBus }
             this.updateIndication();
         });
 
-        sub.on('mda').whenChanged().handle((mda) => {
-            // TODO get a real word
-            this.mda.value = mda;
-            this.mda.ssm = mda > 0 ? Arinc429SignStatusMatrix.NormalOperation : Arinc429SignStatusMatrix.NoComputedData;
+        sub.on('mdaAr').withArinc429Precision(0).handle((mda) => {
+            this.mda.value = mda.value;
+            this.mda.ssm = mda.ssm;
             this.updateIndication();
         });
 
@@ -664,7 +663,7 @@ class AltimeterIndicator extends DisplayComponent<AltimeterIndicatorProps> {
 
  interface MetricAltIndicatorState {
     altitude: Arinc429Word;
-    MDA: number;
+    MDA: Arinc429Word;
     targetAlt: number;
     altitudeColor: TargetAltitudeColor;
     metricAltToggle: boolean;
@@ -687,7 +686,7 @@ class MetricAltIndicator extends DisplayComponent<MetricAltIndicatorProps> {
 
     private state: MetricAltIndicatorState = {
         altitude: new Arinc429Word(0),
-        MDA: 0,
+        MDA: new Arinc429Word(0),
         altitudeColor: TargetAltitudeColor.Cyan,
         targetAlt: 0,
         metricAltToggle: false,
@@ -698,7 +697,7 @@ class MetricAltIndicator extends DisplayComponent<MetricAltIndicatorProps> {
 
         const sub = this.props.bus.getSubscriber<PFDSimvars & Arinc429Values & ClockEvents & SimplaneValues>();
 
-        sub.on('mda').whenChanged().handle((mda) => {
+        sub.on('mdaAr').withArinc429Precision(0).handle((mda) => {
             this.state.MDA = mda;
             this.needsUpdate = true;
         });
@@ -748,7 +747,7 @@ class MetricAltIndicator extends DisplayComponent<MetricAltIndicatorProps> {
 
                 this.updateAltitudeColor();
 
-                if (this.state.altitude.value < this.state.MDA) {
+                if (!this.state.MDA.isNoComputedData() && this.state.altitude.value < this.state.MDA.value) {
                     this.metricAltText.instance.classList.replace('Green', 'Amber');
                 } else {
                     this.metricAltText.instance.classList.replace('Amber', 'Green');

fbw-a32nx/src/systems/instruments/src/PFD/AttitudeIndicatorHorizon.tsx

@@ -321,7 +321,7 @@ class RadioAltAndDH extends DisplayComponent<{ bus: EventBus, filteredRadioAltit
 
     private roll = new Arinc429Word(0);
 
-    private dh = 0;
+    private dh = new Arinc429Word(0);
 
     private filteredRadioAltitude = 0;
 
@@ -352,7 +352,7 @@ class RadioAltAndDH extends DisplayComponent<{ bus: EventBus, filteredRadioAltit
             this.roll = roll;
         });
 
-        sub.on('dh').whenChanged().handle((dh) => {
+        sub.on('dhAr').withArinc429Precision(0).handle((dh) => {
             this.dh = dh;
         });
 
@@ -382,15 +382,15 @@ class RadioAltAndDH extends DisplayComponent<{ bus: EventBus, filteredRadioAltit
                 const chosenTransalt = this.fmgcFlightPhase <= 3 ? this.transAlt : this.transAltAppr;
                 const belowTransitionAltitude = chosenTransalt !== 0 && (!this.altitude.isNoComputedData() && !this.altitude.isNoComputedData()) && this.altitude.value < chosenTransalt;
                 let size = 'FontLarge';
-                const DHValid = this.dh >= 0;
+                const DHValid = this.dh.value >= 0 && (!this.dh.isNoComputedData() && !this.dh.isFailureWarning());
 
                 let text = '';
                 let color = 'Amber';
 
                 if (raHasData) {
                     if (raFailed) {
                         if (raValue < 2500) {
-                            if (raValue > 400 || (raValue > this.dh + 100 && DHValid)) {
+                            if (raValue > 400 || (raValue > this.dh.value + 100 && DHValid)) {
                                 color = 'Green';
                             }
                             if (raValue < 400) {
@@ -400,7 +400,7 @@ class RadioAltAndDH extends DisplayComponent<{ bus: EventBus, filteredRadioAltit
                                 text = Math.round(raValue).toString();
                             } else if (raValue <= 50) {
                                 text = (Math.round(raValue / 5) * 5).toString();
-                            } else if (raValue > 50 || (raValue > this.dh + 100 && DHValid)) {
+                            } else if (raValue > 50 || (raValue > this.dh.value + 100 && DHValid)) {
                                 text = (Math.round(raValue / 10) * 10).toString();
                             }
                         }
@@ -411,7 +411,7 @@ class RadioAltAndDH extends DisplayComponent<{ bus: EventBus, filteredRadioAltit
                 }
 
                 this.daRaGroup.instance.style.transform = `translate3d(0px, ${-verticalOffset}px, 0px)`;
-                if (raFailed && DHValid && raValue <= this.dh) {
+                if (raFailed && DHValid && raValue <= this.dh.value) {
                     this.attDhText.instance.style.visibility = 'visible';
                 } else {
                     this.attDhText.instance.style.visibility = 'hidden';

fbw-a32nx/src/systems/instruments/src/PFD/DigitalAltitudeReadout.tsx

@@ -1,3 +1,4 @@
+import { Arinc429Word } from '@shared/arinc429';
 import { DisplayComponent, EventBus, FSComponent, NodeReference, Subject, Subscribable, VNode } from 'msfssdk';
 import { Arinc429Values } from './shared/ArincValueProvider';
 import { PFDSimvars } from './shared/PFDSimvarPublisher';
@@ -52,7 +53,7 @@ interface DigitalAltitudeReadoutProps {
 }
 
 export class DigitalAltitudeReadout extends DisplayComponent<DigitalAltitudeReadoutProps> {
-    private mda = 0;
+    private mda = new Arinc429Word(0);
 
     private altitude = 0;
 
@@ -81,7 +82,7 @@ export class DigitalAltitudeReadout extends DisplayComponent<DigitalAltitudeRead
 
         const sub = this.props.bus.getSubscriber<PFDSimvars & Arinc429Values>();
 
-        sub.on('mda').whenChanged().handle((mda) => {
+        sub.on('mdaAr').withArinc429Precision(0).handle((mda) => {
             this.mda = mda;
             this.updateColor();
         });
@@ -132,7 +133,7 @@ export class DigitalAltitudeReadout extends DisplayComponent<DigitalAltitudeRead
     }
 
     private updateColor() {
-        const color = (this.mda !== 0 && this.altitude < this.mda) ? 'Amber' : 'Green';
+        const color = ((!this.mda.isNoComputedData() && !this.mda.isFailureWarning()) && this.mda.value !== 0 && this.altitude < this.mda.value) ? 'Amber' : 'Green';
         this.colorSub.set(color);
     }
 

fbw-a32nx/src/systems/instruments/src/PFD/FMA.tsx

@@ -1415,28 +1415,28 @@ class D3Cell extends DisplayComponent<{bus: EventBus}> {
     onAfterRender(node: VNode): void {
         super.onAfterRender(node);
 
-        const sub = this.props.bus.getSubscriber<PFDSimvars>();
+        const sub = this.props.bus.getSubscriber<PFDSimvars & Arinc429Values>();
 
-        sub.on('mda').whenChanged().handle((mda) => {
-            if (mda !== 0) {
-                const MDAText = Math.round(mda).toString().padStart(6, ' ');
+        sub.on('mdaAr').withArinc429Precision(0).handle((mda) => {
+            if ((!mda.isNoComputedData() && !mda.isFailureWarning()) && mda.value !== 0) {
+                const MDAText = Math.round(mda.value).toString().padStart(6, ' ');
 
                 this.textRef.instance.innerHTML = `<tspan>BARO</tspan><tspan class="Cyan" xml:space="preserve">${MDAText}</tspan>`;
             } else {
                 this.textRef.instance.innerHTML = '';
             }
         });
 
-        sub.on('dh').whenChanged().handle((dh) => {
+        sub.on('dhAr').withArinc429Precision(0).handle((dh) => {
             let fontSize = 'FontSmallest';
-
-            if (dh !== -1 && dh !== -2) {
-                const DHText = Math.round(dh).toString().padStart(4, ' ');
+            const dhValue = dh.value;
+            if ((!dh.isNoComputedData() && !dh.isFailureWarning()) && dhValue !== -1 && dhValue !== -2) {
+                const DHText = Math.round(dhValue).toString().padStart(4, ' ');
 
                 this.textRef.instance.innerHTML = `
                         <tspan>RADIO</tspan><tspan class="Cyan" xml:space="preserve">${DHText}</tspan>
                     `;
-            } else if (dh === -2) {
+            } else if ((!dh.isNoComputedData() && !dh.isFailureWarning()) && dhValue === -2) {
                 this.textRef.instance.innerHTML = '<tspan>NO DH</tspan>';
                 fontSize = 'FontMedium';
             } else {

fbw-a32nx/src/systems/instruments/src/PFD/shared/ArincValueProvider.ts

@@ -43,6 +43,8 @@ export interface Arinc429Values {
     irMaintWord: Arinc429Word;
     trueHeading: Arinc429Word;
     trueTrack: Arinc429Word;
+    mdaAr: Arinc429Word;
+    dhAr: Arinc429Word;
 }
 export class ArincValueProvider {
     private roll = new Arinc429Word(0);
@@ -479,6 +481,14 @@ export class ArincValueProvider {
         subscriber.on('trueTrackRaw').handle((word) => {
             publisher.pub('trueTrack', new Arinc429Word(word));
         });
+
+        subscriber.on('mda').handle((word) => {
+            publisher.pub('mdaAr', new Arinc429Word(word));
+        });
+
+        subscriber.on('dh').handle((word) => {
+            publisher.pub('dhAr', new Arinc429Word(word));
+        });
     }
 
     private determineAndPublishChosenRadioAltitude(publisher: Publisher<Arinc429Values>) {

fbw-a32nx/src/systems/instruments/src/PFD/shared/PFDSimvarPublisher.tsx

@@ -183,8 +183,8 @@ export enum PFDVars {
     athrModeMessage = 'L:A32NX_AUTOTHRUST_MODE_MESSAGE',
     machPreselVal = 'L:A32NX_MachPreselVal',
     speedPreselVal = 'L:A32NX_SpeedPreselVal',
-    mda = 'L:AIRLINER_MINIMUM_DESCENT_ALTITUDE',
-    dh = 'L:AIRLINER_DECISION_HEIGHT',
+    mda = 'L:A32NX_FM1_MINIMUM_DESCENT_ALTITUDE',
+    dh = 'L:A32NX_FM1_DECISION_HEIGHT',
     attHdgKnob = 'L:A32NX_ATT_HDG_SWITCHING_KNOB',
     airKnob = 'L:A32NX_AIR_DATA_SWITCHING_KNOB',
     vsBaro = 'L:A32NX_ADIRS_ADR_1_BAROMETRIC_VERTICAL_SPEED',