-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fmgc): minimums exposed by fmgc #7887
feat(fmgc): minimums exposed by fmgc #7887
Conversation
…senMohr/a32nx into a32nx-minimums-exposed-by-fmgc
@2hwk I found the reason it broke remote MCDU. Was a small thing missing that must have created exceptions that blocked Simbridge connection. |
.../html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/FMC/A32NX_FMCMainDisplay.js
Outdated
Show resolved
Hide resolved
.../html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/FMC/A32NX_FMCMainDisplay.js
Outdated
Show resolved
Hide resolved
@MikioDK Could you please add testing instructions specifically around the minimums? E.g. BARO minimums should not appear on the PFD during takeoff in the top corner or on the alt band etc. |
I think the PFD is the important one. The FWC doesn't really matter because of the new Rust FWC, I'll start consuming it there once it's available. But I think updating the PFD would make sense. |
I concur with beheh. 👍 |
…show Minimum effects when NormalOperation
fbw-a32nx/src/systems/instruments/src/PFD/AttitudeIndicatorHorizon.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fbw-a32nx/src/systems/instruments/src/PFD/AltitudeIndicator.tsx
Outdated
Show resolved
Hide resolved
fbw-a32nx/src/systems/instruments/src/PFD/AltitudeIndicator.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
QA Test Report:
Result:
Conclusions: |
…senMohr/a32nx into a32nx-minimums-exposed-by-fmgc
Error was due to other ARINC429 changes that got merged in from master. PFD now loads |
QA Report Testing:
Negatives:
Results:
Conclusions:
|
Fixes #7610
Summary of Changes
The minimums get set through the BnrArinc when in CRZ or later and within 200NM of the destinition
Screenshots (if necessary)
References
https://discord.com/channels/738864299392630914/850710355877560350/1044558618982363176
and the issue itself #7610
Additional context
Discord username (if different from GitHub):
Mikio
Testing instructions
Test that displays and general aircraft operation is still okay.
Test that remote MCDU is working.
BARO minimums should not appear on the PFD during takeoff in the top corner or on the alt band.
BARO minimums should not make the altitude indicator, or meter altitude band Amber in color during takeoff.
RADIO minimums should not appear on the PFD during takeoff in the top corner.
RADIO minimums should not make the RA value on the bottom of Artifical Horizon on PFD green on takeoff.
BARO minimums should appear on the PFD when in a phase later than Cruise or if in Cruise and within 250NM of destination.
RADIO minimums should appear on the PFD when in a phase later than Cruise or if in Cruise and within 250NM of destination.
BARO minimums should make the altitude indicator amber when passing the minimums as normal, while having minimums displayed on FPD.
RADIO minimums should make the altitude indicator amber when passing the minimums as normal, while having minimums displayed on FPD
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.