[compiler][patch] Throw todo when encountering fbt param with unicode or double quote

compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/CodegenReactiveFunction.ts

@@ -2205,7 +2205,7 @@ function codegenInstructionValue(
  * u00A0 to uFFFF: All non-basic Latin characters
  * https://en.wikipedia.org/wiki/List_of_Unicode_characters#Control_codes
  */
-const STRING_REQUIRES_EXPR_CONTAINER_PATTERN =
+export const STRING_REQUIRES_EXPR_CONTAINER_PATTERN =
   /[\u{0000}-\u{001F}\u{007F}\u{0080}-\u{FFFF}]|"/u;
 function codegenJsxAttribute(
   cx: Context,

compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/MemoizeFbtAndMacroOperandsInSameScope.ts

@@ -5,13 +5,15 @@
  * LICENSE file in the root directory of this source tree.
  */
 
+import { CompilerError } from "..";
 import {
   HIRFunction,
   IdentifierId,
   makeInstructionId,
   Place,
   ReactiveValue,
 } from "../HIR";
+import { STRING_REQUIRES_EXPR_CONTAINER_PATTERN } from "./CodegenReactiveFunction";
 import { eachReactiveValueOperand } from "./visitors";
 
 /**
@@ -52,6 +54,25 @@ export function memoizeFbtAndMacroOperandsInSameScope(fn: HIRFunction): void {
       break;
     }
   }
+
+  /**
+   * Hack in a check to ensure that we don't produce invalid ASTs in codegen
+   * (see https://github.com/facebook/react/pull/29997 and `fbt-param-with-quotes` fixture)
+   */
+  for (const [, block] of fn.body.blocks) {
+    for (const { lvalue, value } of block.instructions) {
+      if (fbtValues.has(lvalue.identifier.id) && value.kind === "Primitive") {
+        if (typeof value.value === "string") {
+          if (STRING_REQUIRES_EXPR_CONTAINER_PATTERN.test(value.value)) {
+            CompilerError.throwTodo({
+              reason: "Handle non-ascii character in fbt-like macro operand",
+              loc: value.loc,
+            });
+          }
+        }
+      }
+    }
+  }
 }
 
 export const FBT_TAGS: Set<string> = new Set([

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/fbt/error.todo-fbt-param-with-quotes.expect.md

@@ -0,0 +1,36 @@
+
+## Input
+
+```javascript
+import fbt from "fbt";
+
+function Component(props) {
+  const element = (
+    <fbt desc={"Dialog to show to user"}>
+      Hello <fbt:param name='"user" name'>{props.name}</fbt:param>
+    </fbt>
+  );
+  return element.toString();
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{ name: "Jason" }],
+};
+
+```
+
+
+## Error
+
+```
+  4 |   const element = (
+  5 |     <fbt desc={"Dialog to show to user"}>
+> 6 |       Hello <fbt:param name='"user" name'>{props.name}</fbt:param>
+    |                             ^^^^^^^^^^^^^ Todo: Handle non-ascii character in fbt-like macro operand (6:6)
+  7 |     </fbt>
+  8 |   );
+  9 |   return element.toString();
+```
+
+

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/fbt/error.todo-fbt-param-with-quotes.js

@@ -0,0 +1,15 @@
+import fbt from "fbt";
+
+function Component(props) {
+  const element = (
+    <fbt desc={"Dialog to show to user"}>
+      Hello <fbt:param name='"user" name'>{props.name}</fbt:param>
+    </fbt>
+  );
+  return element.toString();
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{ name: "Jason" }],
+};

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/fbt/error.todo-fbt-param-with-unicode.expect.md

@@ -24,7 +24,13 @@ export const FIXTURE_ENTRYPOINT = {
 ## Error
 
 ```
-Property arguments[0] of CallExpression expected node to be of a type ["Expression","SpreadElement","JSXNamespacedName","ArgumentPlaceholder"] but instead got "JSXExpressionContainer"
+  4 |   const element = (
+  5 |     <fbt desc={"Dialog to show to user"}>
+> 6 |       Hello <fbt:param name="user name ☺">{props.name}</fbt:param>
+    |                             ^^^^^^^^^^^^^ Todo: Handle non-ascii character in fbt-like macro operand (6:6)
+  7 |     </fbt>
+  8 |   );
+  9 |   return element.toString();
 ```