Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler][patch] Throw todo when encountering fbt param with unicode or double quote #30384

Closed
wants to merge 1 commit into from
Closed

[compiler][patch] Throw todo when encountering fbt param with unicode or double quote #30384

wants to merge 1 commit into from

Conversation

mofeiZ
Copy link
Contributor

@mofeiZ mofeiZ commented Jul 18, 2024 •
edited
Loading

@mofeiZ mofeiZ mentioned this pull request Jul 18, 2024
Merged
mofeiZ added a commit that referenced this pull request Jul 18, 2024
@mofeiZ
[compiler][patch] Throw todo when encountering fbt param with unicode…
bdc3b61 
… or double quote

ghstack-source-id: 14c1dd0f9859cfeac0aa97527f53230a2fb07bee
Pull Request resolved: #30384
@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 6:45pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 18, 2024
@mofeiZ mofeiZ marked this pull request as ready for review July 18, 2024 18:39
@react-sizebot
Copy link

Comparing: 512b09b...1a24f30

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 499.44 kB 499.44 kB = 89.59 kB 89.59 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 504.26 kB 504.26 kB = 90.30 kB 90.30 kB
facebook-www/ReactDOM-prod.classic.js = 599.20 kB 599.20 kB = 105.79 kB 105.79 kB
facebook-www/ReactDOM-prod.modern.js = 573.37 kB 573.37 kB = 101.68 kB 101.68 kB
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Generated by 🚫 dangerJS against 1a24f30

@mofeiZ
Copy link
Contributor Author

mofeiZ commented Jul 18, 2024

Looks like we have a decent amount of new-lines within fbt-param names internally, so let's handle this correctly in codegen

@mofeiZ mofeiZ closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mofeiZ @react-sizebot @facebook-github-bot