Update gen_for_multiple_trials_with_multiple_models to call into gen_with_multiple_nodes #2822
+287
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In extending gen_multiple_trials_with_multiple models, we realized that gen_with_multiple_nodes doesn't currently handle pending points gracefully. This diff ensure that points generated from one node are considered pending for the next node in a single trial's gen loop (and so forth for any number of nodes). Reviewed By: saitcakmak Differential Revision: D63785539
…with_multiple_nodes Summary: This should be a no-op on the logic, since we aren't actually using quickbo anywhere, but this diff makes gen_with_multiple_nodes a sub-method of gen_multiple_trials_with_multiple_models and makes the later the primary entry point into GS. We update the method in all locations it's defined. We also ensure that pending points are handled correctly by gen_multiple_trials_with_multiple_models, and ensure backwards compatability with all live GS. Differential Revision: D63657844
|
This pull request was exported from Phabricator. Differential Revision: D63657844 |
facebook-github-bot
added
CLA Signed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2822 +/- ##
=======================================
Coverage 95.70% 95.70%
=======================================
Files 492 492
Lines 48548 48599 +51
=======================================
+ Hits 46464 46513 +49
- Misses 2084 2086 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This should be a no-op on the logic, since we aren't actually using quickbo anywhere, but this diff makes gen_with_multiple_nodes a sub-method of gen_multiple_trials_with_multiple_models and makes the later the primary entry point into GS. We update the method in all locations it's defined.
We also ensure that pending points are handled correctly by gen_multiple_trials_with_multiple_models, and ensure backwards compatability with all live GS.
Differential Revision: D63657844