Update gen_with_multiple_nodes to handle pending points #2817
+138
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63785539 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2817 +/- ##
=======================================
Coverage 95.72% 95.72%
=======================================
Files 492 492
Lines 48566 48601 +35
=======================================
+ Hits 46489 46524 +35
Misses 2077 2077 ☔ View full report in Codecov by Sentry. |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 3, 2024
Summary: In extending gen_multiple_trials_with_multiple models, we realized that gen_with_multiple_nodes doesn't currently handle pending points gracefully. This diff ensure that points generated from one node are considered pending for the next node in a single trial's gen loop (and so forth for any number of nodes). Reviewed By: saitcakmak Differential Revision: D63785539
mgarrard
force-pushed
the
export-D63785539
branch
from
66e1c5a
to
2aed5d3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63785539 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 3, 2024
Summary: In extending gen_multiple_trials_with_multiple models, we realized that gen_with_multiple_nodes doesn't currently handle pending points gracefully. This diff ensure that points generated from one node are considered pending for the next node in a single trial's gen loop (and so forth for any number of nodes). Reviewed By: saitcakmak Differential Revision: D63785539
mgarrard
force-pushed
the
export-D63785539
branch
from
2aed5d3
to
2c00125
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63785539 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 3, 2024
Summary: In extending gen_multiple_trials_with_multiple models, we realized that gen_with_multiple_nodes doesn't currently handle pending points gracefully. This diff ensure that points generated from one node are considered pending for the next node in a single trial's gen loop (and so forth for any number of nodes). Reviewed By: saitcakmak Differential Revision: D63785539
mgarrard
force-pushed
the
export-D63785539
branch
from
2c00125
to
9eb66ff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63785539 |
Summary: In extending gen_multiple_trials_with_multiple models, we realized that gen_with_multiple_nodes doesn't currently handle pending points gracefully. This diff ensure that points generated from one node are considered pending for the next node in a single trial's gen loop (and so forth for any number of nodes). Reviewed By: saitcakmak Differential Revision: D63785539
mgarrard
force-pushed
the
export-D63785539
branch
from
9eb66ff
to
0014ee4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63785539 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 3, 2024
Summary: In extending gen_multiple_trials_with_multiple models, we realized that gen_with_multiple_nodes doesn't currently handle pending points gracefully. This diff ensure that points generated from one node are considered pending for the next node in a single trial's gen loop (and so forth for any number of nodes). Reviewed By: saitcakmak Differential Revision: D63785539
|
This pull request has been merged in 331da3a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In extending gen_multiple_trials_with_multiple models, we realized that gen_with_multiple_nodes doesn't currently handle pending points gracefully. This diff ensure that points generated from one node are considered pending for the next node in a single trial's gen loop (and so forth for any number of nodes).
Differential Revision: D63785539