Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set tag env var in rc release script #4897

Merged
merged 1 commit into from
Mar 4, 2022
Merged

set tag env var in rc release script #4897

merged 1 commit into from
Mar 4, 2022

Conversation

aclevername
Copy link
Contributor

it was set in the regular release script and not the RC, which is what caught me out in #4873

@aclevername aclevername added the skip-release-notes Causes PR not to show in release notes label Mar 4, 2022
cPu1
cPu1 approved these changes Mar 4, 2022
View reviewed changes
Copy link
Collaborator

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aclevername aclevername enabled auto-merge (squash) March 4, 2022 09:49
@aclevername aclevername merged commit 1b0731f into eksctl-io:main Mar 4, 2022
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

@nikimanoledaki nikimanoledaki nikimanoledaki approved these changes

@Skarlso Skarlso Awaiting requested review from Skarlso

Assignees
No one assigned
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclevername @cPu1 @nikimanoledaki