Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish releases on the v prefix'd tag #4873

Merged
merged 3 commits into from
Mar 3, 2022

Conversation

aclevername
Copy link
Contributor

@aclevername aclevername commented Mar 2, 2022

Description

Closes #4858

its super unclear how goreleaser decides what version to use for the release. This workflows trigger on the x.x.x tags (without the v prefix). You can use an environment variable to configure this GORELEASER_CURRENT_TAG https://goreleaser.com/customization/build/?h=goreleaser_current_tag#define-build-tag. I'm setting with env var with the v prefix to change the version

@aclevername aclevername added the skip-release-notes Causes PR not to show in release notes label Mar 2, 2022
@aclevername aclevername marked this pull request as draft March 2, 2022 17:38
@aclevername
Copy link
Contributor Author

aclevername commented Mar 2, 2022

just realised this will break how we read the release notes file. Now I am even more confused about how this worked before

modified

@aclevername aclevername requested a review from Skarlso March 3, 2022 09:19
@aclevername aclevername marked this pull request as ready for review March 3, 2022 09:21
@aclevername aclevername changed the title publish releases on pushes to the v prefixed tag publish releases on the v prefix'd tag Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

releases are tagged sometimes with v prefix and sometimes without
3 participants